From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUyRp-0000zp-BH for qemu-devel@nongnu.org; Mon, 28 Nov 2011 05:28:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUyRl-0002Mc-5w for qemu-devel@nongnu.org; Mon, 28 Nov 2011 05:28:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUyRk-0002J9-U5 for qemu-devel@nongnu.org; Mon, 28 Nov 2011 05:28:25 -0500 Message-ID: <4ED36240.9020401@redhat.com> Date: Mon, 28 Nov 2011 12:28:16 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1322447198-6328-1-git-send-email-jordan.l.justen@intel.com> In-Reply-To: <1322447198-6328-1-git-send-email-jordan.l.justen@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 0/2] PC system flash support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: qemu-devel@nongnu.org On 11/28/2011 04:26 AM, Jordan Justen wrote: > Enable flash emulation in a PC system using pflash_cfi01. > > The new memory layout should be made conditional on the machine type (-M pc-1.1 or later) to allow migration from/to pc-1.0 and earlier. Memory layout in this context are the names of memory ranges given to memory_region_init_ram(), sizes, and locations. Also, the flash interface should not be there for older machines. -- error compiling committee.c: too many arguments to function