From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: agraf@suse.de, qemu-devel@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features
Date: Mon, 28 Nov 2011 16:38:12 -0600 [thread overview]
Message-ID: <4ED40D54.5030500@codemonkey.ws> (raw)
In-Reply-To: <4ECF508E.5050709@redhat.com>
On 11/25/2011 02:23 AM, Paolo Bonzini wrote:
> On 11/24/2011 06:55 PM, Michael S. Tsirkin wrote:
>> > Could some backend make it a hard failure?
>>
>> I don't see how, there's no way to report a failure from
>> an io port write.
>
> You can exit(1), or fall back to a restricted set of features like we do for
> BAD_FEATURE. BAD_FEATURE is a special case of features that is not exposed by
> the host, but requested by the guest.
>
>> > If I understand
>> > correctly, this would have prevented the BAD_FEATURE bug too.
>>
>> Which bug?
>
> VIRTIO_F_BAD_FEATURE(30)
> This feature should never be negotiated by the guest; doing so is an indication
> that the guest is faulty. An experimental virtio PCI driver contained in Linux
> version 2.6.25 had this problem, and this feature bit can be used to detect it.
>
>> what would have prevented it.
>
> exit(1) on unsupported features.
Applied. Thanks.
Regards,
Anthony Liguori
>
> Paolo
>
>
prev parent reply other threads:[~2011-11-28 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 12:28 [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features Paolo Bonzini
2011-11-24 16:42 ` Michael S. Tsirkin
2011-11-24 16:49 ` Paolo Bonzini
2011-11-24 17:55 ` Michael S. Tsirkin
2011-11-25 8:23 ` Paolo Bonzini
2011-11-26 20:45 ` Michael S. Tsirkin
2011-11-28 22:38 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED40D54.5030500@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=agraf@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).