From: Mark Wu <wudxw@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qed: limit to image size in qed_find_cluster()
Date: Tue, 29 Nov 2011 13:01:52 +0800 [thread overview]
Message-ID: <4ED46740.3090108@linux.vnet.ibm.com> (raw)
In-Reply-To: <1322497100-24167-1-git-send-email-stefanha@linux.vnet.ibm.com>
On 11/29/2011 12:18 AM, Stefan Hajnoczi wrote:
> Callers of bdrv_is_allocated() may go beyond the end of the image. For
> general robustness we should limit to the end of the image so that
> callers don't end up using out-of-range sector counts and receive -EIO.
It seems the same problem exists in qcow/qcow2, why do we not add the
limit in bdrv_is_allocated? Then it can cover all formats.
Actually, I can't figure out how the caller can go beyond the end of the
image. If the I/O request for sectors beyond image size comes from
guest, it should be dropped in the guest block layer. If the request
comes from qemu, like block streaming, it should also honor the image
size, right?
Mark.
next prev parent reply other threads:[~2011-11-29 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:18 [Qemu-devel] [PATCH] qed: limit to image size in qed_find_cluster() Stefan Hajnoczi
2011-11-29 5:01 ` Mark Wu [this message]
2011-11-29 13:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED46740.3090108@linux.vnet.ibm.com \
--to=wudxw@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).