From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RVJDE-0001Yt-Jd
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:38:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RVJDD-0003WD-HY
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:38:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RVJDD-0003Vt-9S
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:38:47 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAT8cjOI009892
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 29 Nov 2011 03:38:45 -0500
Message-ID: <4ED49A13.9050200@redhat.com>
Date: Tue, 29 Nov 2011 09:38:43 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1322138308-31040-1-git-send-email-pbonzini@redhat.com>
	<1322138308-31040-5-git-send-email-pbonzini@redhat.com>
	<20111128184617.GC13778@redhat.com>
In-Reply-To: <20111128184617.GC13778@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/9] virtio-9p: remove PCI dependencies
	from hw/9pfs/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/28/2011 07:46 PM, Michael S. Tsirkin wrote:
>> >  +#ifdef CONFIG_LINUX
>> >  +static int virtio_9p_init_pci(PCIDevice *pci_dev)
>> >  +{
>> >  +    VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev);
>> >  +    VirtIODevice *vdev;
>> >  +
>> >  +    vdev = virtio_9p_init(&pci_dev->qdev,&proxy->fsconf);
>> >  +    vdev->nvectors = proxy->nvectors;
>> >  +    virtio_init_pci(proxy, vdev);
>> >  +    /* make the actual value visible */
>> >  +    proxy->nvectors = vdev->nvectors;
>> >  +    return 0;
>> >  +}
>> >  +#endif
>> >  +
> This ifdef looks wrong to me - is there no way 9p can thinkably
> work on non-linux hosts? If yes, we should have a separate config
> entry for 9p, configure script can make it
> conditional on linux host.

I think it was true in the beginning, but more recent versions should 
only depend on CONFIG_POSIX.  I will set up FreeBSD and come back.

Paolo