From: Avi Kivity <avi@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] exec.c: Fix subpage memory access to RAM MemoryRegion
Date: Tue, 29 Nov 2011 16:00:12 +0200 [thread overview]
Message-ID: <4ED4E56C.9090507@redhat.com> (raw)
In-Reply-To: <4ED4D446.3010508@suse.de>
On 11/29/2011 02:47 PM, Andreas Färber wrote:
> >
> > addr += mmio->region_offset[idx];
> > idx = mmio->sub_io_index[idx];
> > + if (unlikely(idx == IO_MEM_RAM)) {
> > + ram_addr_t raddr = /*mmio->base |*/ addr;
> > + void *ptr = qemu_get_ram_ptr(raddr);
>
> ...and/or this seems to lead to "Bad RAM pointer" (or so) when there's
> ELF code loaded into the subpage at that address despite being IO_MEM_RAM?
> (Seen, e.g., if for RL78 I increase the page size from 12 to 16.)
>
addr is relative to the start of the page, instead of the start of the
region. You can use mmio->region_offset[idx] to compensate.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-29 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 15:06 [Qemu-devel] [PATCH] exec.c: Fix subpage memory access to RAM MemoryRegion Andreas Färber
2011-11-28 17:17 ` Avi Kivity
2011-11-28 22:39 ` Andreas Färber
2011-11-29 9:52 ` Avi Kivity
2011-11-30 15:34 ` Andreas Färber
2011-11-29 12:47 ` Andreas Färber
2011-11-29 14:00 ` Avi Kivity [this message]
2011-11-29 16:19 ` Andreas Färber
2011-11-29 16:46 ` Avi Kivity
2011-11-30 16:22 ` Andreas Färber
2011-12-01 9:24 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED4E56C.9090507@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).