From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RVJ4h-0007fq-TH
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:30:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RVJ4g-0001vN-Cv
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:29:59 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:46981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlspirat42@gmail.com>) id 1RVJ4g-0001vF-9M
	for qemu-devel@nongnu.org; Tue, 29 Nov 2011 03:29:58 -0500
Received: by iakk32 with SMTP id k32so11653435iak.4
	for <qemu-devel@nongnu.org>; Tue, 29 Nov 2011 00:29:56 -0800 (PST)
Message-ID: <4ED5168E.5080304@gmail.com>
Date: Wed, 30 Nov 2011 02:29:50 +0900
From: Benjamin <mlspirat42@gmail.com>
MIME-Version: 1.0
References: <1322225387-15073-1-git-send-email-mlspirat42@gmail.com>
	<CAJSP0QUFFafNJuUCNQ6f8A+qG0BRPK9QGqO6yQCK_pdbdzY=Vw@mail.gmail.com>
In-Reply-To: <CAJSP0QUFFafNJuUCNQ6f8A+qG0BRPK9QGqO6yQCK_pdbdzY=Vw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Support for UDP unicast network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: andreas.faerber@web.de, jan.kiszka@web.de, qemu-devel@nongnu.org, Benjamin MARSILI <marsil_b@epitech.eu>

On 11/28/11 20:39, Stefan Hajnoczi wrote:
> On Fri, Nov 25, 2011 at 12:49 PM, Benjamin<mlspirat42@gmail.com>  wrote:
>> +    fd = qemu_socket(PF_INET, SOCK_DGRAM, 0);
>> +    if (fd<  0) {
>> +        perror("socket(PF_INET, SOCK_DGRAM)");
>> +        return -1;
>> +    }
>> +    val = 1;
>> +    ret = setsockopt(fd, SOL_SOCKET, SO_REUSEADDR,
>> +                   (const char *)&val, sizeof(val));
>> +    if (ret<  0) {
>> +        perror("setsockopt(SOL_SOCKET, SO_REUSEADDR)");
>
> Please avoid leaking the file descriptor on error:
> closesocket(fd);
>
> Since existing code also does this it may be more appropriate to send
> a follow-up patch that cleans up all of net/socket.c.
>
> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>
> Stefan

I can do that. However is it really a leak considering the fact that
the program will call exit just after?
If it's a matter of consistency and coding style I would understand
though.

One more thing, git-format-patch added a "From" field to the header and
caused this glitch in the mail. I thought git-send-mail or the mail
server would handle it well but apparently not:

 From 2f5b85fcadcfee3b75a6a21dc86d10b945c99f0f Mon Sep 17 00:00:00 2001
From: Benjamin MARSILI <marsil_b@epitech.eu>

git-am didn't complain with the patch that I sent but it may break after
gmail relayed it 
(http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg03152.html).
The second from header is interpreted as text... Should I remove the
first "From" field before sending the patch?

Sorry for the noise on the ML and thanks to all those who helped me get
involved.

Benjamin