From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RW2xq-0006lS-4L for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:29:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RW2xk-0008H4-JR for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:29:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RW2xk-0008Gv-5y for qemu-devel@nongnu.org; Thu, 01 Dec 2011 04:29:52 -0500 Message-ID: <4ED7490C.7050505@redhat.com> Date: Thu, 01 Dec 2011 11:29:48 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1322666781-6108-1-git-send-email-afaerber@suse.de> In-Reply-To: <1322666781-6108-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, Gleb Natapov On 11/30/2011 05:26 PM, Andreas F=C3=A4rber wrote: > Commit 95c318f5e1f88d7e5bcc6deac17330fd4806a2d3 (Fix segfault in mmio > subpage handling code.) prevented a segfault by making all subpage > registrations over an existing memory page perform an unassigned access. > Symptoms were writes not taking effect and reads returning zero. > > Very small page sizes are not currently supported either, > so subpage memory areas cannot fully be avoided. > > Therefore change the previous fix to use a new IO_MEM_SUBPAGE_RAM > instead of IO_MEM_UNASSIGNED. Suggested by Avi. > > Looks reasonable. Should go into 1.1. Should we backport it to 1.0.blah? From 95c318f's description, it doesn't happen in normal circumstances. --=20 error compiling committee.c: too many arguments to function