From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6ne-0000yO-67
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:35:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6nZ-0000Sn-Tq
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:35:42 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:60743)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6nZ-0000Sj-MU
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:35:37 -0500
Received: by yenq3 with SMTP id q3so2218691yen.4
	for <qemu-devel@nongnu.org>; Thu, 01 Dec 2011 05:35:28 -0800 (PST)
Message-ID: <4ED7829D.2000902@codemonkey.ws>
Date: Thu, 01 Dec 2011 07:35:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>	<1322687028-29714-14-git-send-email-aliguori@us.ibm.com>
	<20111201110739.GD31730@stefanha-thinkpad.localdomain>
In-Reply-To: <20111201110739.GD31730@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/18] rtc: make piix3 set the rtc as a
	child
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 12/01/2011 05:07 AM, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2011 at 03:03:43PM -0600, Anthony Liguori wrote:
>> +    /* FIXME there's some major spaghetti here.  Somehow we create the devices
>> +     * on the PIIX before we actually create it.  We create the PIIX3 deep in
>> +     * the recess of the i440fx creation too and then loose the DeviceState.
>
> s/loose/lose/

Ack.

Regards,

Anthony Liguori