From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6rk-00035C-WE
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:39:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6rg-0001ZP-Pd
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:39:56 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:61690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RW6rg-0001ZL-Lo
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 08:39:52 -0500
Received: by ywe9 with SMTP id 9so2371936ywe.4
	for <qemu-devel@nongnu.org>; Thu, 01 Dec 2011 05:39:52 -0800 (PST)
Message-ID: <4ED783A5.4050308@codemonkey.ws>
Date: Thu, 01 Dec 2011 07:39:49 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>	<1322687028-29714-18-git-send-email-aliguori@us.ibm.com>
	<20111201112631.GF31730@stefanha-thinkpad.localdomain>
In-Reply-To: <20111201112631.GF31730@stefanha-thinkpad.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/18] Add test tools
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 12/01/2011 05:26 AM, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2011 at 03:03:47PM -0600, Anthony Liguori wrote:
>> diff --git a/QMP/qom-get b/QMP/qom-get
>> new file mode 100755
>> index 0000000..b086bc5
>> --- /dev/null
>> +++ b/QMP/qom-get
>> @@ -0,0 +1,26 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property getter utility
>
>> +#
>> +# Copyright IBM, Corp. 2011
>> +#
>> +# Authors:
>> +#  Anthony Liguori<aliguori@us.ibm.com>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2 or later.  See
>> +# the COPYING file in the top-level directory.
>> +##
>> +
>> +import sys
>> +from qmp import QEMUMonitorProtocol
>> +
>> +srv = QEMUMonitorProtocol('/tmp/server.sock')
>
> I think it would be worth doing it like QMP/qmp-shell.py and using a
> command-line argument.  We might also like to support a
> QEMU_MONITOR environment variable.
>
> Hardcoding to /tmp/server.sock makes this script less useful.
>
>> diff --git a/QMP/qom-list b/QMP/qom-list
>> new file mode 100755
>> index 0000000..5dbb07b
>> --- /dev/null
>> +++ b/QMP/qom-list
>> @@ -0,0 +1,30 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property listing utility
>
>> diff --git a/QMP/qom-set b/QMP/qom-set
>> new file mode 100755
>> index 0000000..83a4394
>> --- /dev/null
>> +++ b/QMP/qom-set
>> @@ -0,0 +1,21 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property setter utility


Ack.  I made these changes actually but something got lost when I sent the 
patches out.  I actually used git-publish for the first time and apparently 
screwed something up when setting up the branch :-/

Regards,

Anthony Liguori
>