From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RW7wm-0001R9-65 for qemu-devel@nongnu.org; Thu, 01 Dec 2011 09:49:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RW7wg-0004do-Cu for qemu-devel@nongnu.org; Thu, 01 Dec 2011 09:49:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RW7wg-0004dS-4D for qemu-devel@nongnu.org; Thu, 01 Dec 2011 09:49:06 -0500 Message-ID: <4ED793D8.9000202@redhat.com> Date: Thu, 01 Dec 2011 16:48:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com> <4ED78D33.5040206@redhat.com> <4ED79238.9050504@us.ibm.com> In-Reply-To: <4ED79238.9050504@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino On 12/01/2011 04:42 PM, Anthony Liguori wrote: > >> >> We need good tools to allow easy review of the ABI bits hiding in >> patches, and to maintain ABI compatibility. Something like >> qemu-print-abi that dumps all properties for all devices. Patches could >> show the ABI changes by including a diff of the output of this program >> from before and after a change, and we could add similar tests for >> backwards compatibility. > > I'm not sure that we want this interface to be backwards compatible. > I actually think we should provide a higher level interface that's > explicitly there for compatibility. Probably in the form of a C > library that can be documented and reasoned with better. > Does this force anyone who wants a stable ABI to use this library? I don't have a good picture of this library. If FooState has a bar propery, do you generate qemu_foo_get_bar() and qemu_foo_set_bar() accessors? -- error compiling committee.c: too many arguments to function