From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RW8vU-0003P3-Nf
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 10:51:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RW8vL-0004iC-7K
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 10:51:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55378)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RW8vL-0004hj-0Z
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 10:51:47 -0500
Message-ID: <4ED7A276.4080803@redhat.com>
Date: Thu, 01 Dec 2011 16:51:18 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>
	<1322687028-29714-3-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1322687028-29714-3-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as
 new	style properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

> +    for (prop = dev->info->props; prop && prop->name; prop++) {
> +        qdev_property_add_legacy(dev, prop, NULL);
> +    }

bus properties?

> +static void qdev_get_legacy_property(DeviceState *dev, Visitor *v, void *opaque,
> +                                     const char *name, Error **errp)
> +{
> +    Property *prop = opaque;
> +
> +    if (prop->info->print) {
> +        char buffer[1024];
> +        char *ptr = buffer;
> +
> +        prop->info->print(dev, prop, buffer, sizeof(buffer));
> +        visit_type_str(v, &ptr, name, errp);

I think you can look at prop->info->type here and do something more
clever at least for the bool + integer properties.

cheers,
  Gerd