qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion
Date: Thu, 01 Dec 2011 19:24:14 +0200	[thread overview]
Message-ID: <4ED7B83E.3080300@redhat.com> (raw)
In-Reply-To: <4ED7B6DC.8000300@suse.de>

On 12/01/2011 07:18 PM, Andreas Färber wrote:
> Am 01.12.2011 11:06, schrieb Gleb Natapov:
> > On Thu, Dec 01, 2011 at 11:54:33AM +0200, Avi Kivity wrote:
> >> On 12/01/2011 11:47 AM, Gleb Natapov wrote:
> >>> On Thu, Dec 01, 2011 at 11:41:52AM +0200, Avi Kivity wrote:
> >>>> On 12/01/2011 11:37 AM, Gleb Natapov wrote:
> >>>>>>
> >>>>>> Looks reasonable.  Should go into 1.1.  Should we backport it to
> >>>>>> 1.0.blah?  From 95c318f's description, it doesn't happen in normal
> >>>>>> circumstances.
> >>>>>>
> >>>>> To reproduce that I mappped subpage PCI bar over RAM IIRC. 
> >>>>
> >>>> In qemu 1.0, you can no longer do that (the pci bridge will not let the
> >>>> BAR override the RAM).
> >>>>
> >>>
> >>> Hmm, if this is how real HW work then problem solved :) (different HW can
> >>> behave differently, but it is reasonable to assume that on a PC memory
> >>> access below TOM will be redirected to memory controller no matter what)
>
> Ah, glad to know that x86_64 is no longer affected. What about 0.15.1?

In 0.15 this can still happen, 1.0 was fixed by the memory API.  Note
the fix is actually a side effect of a different change, and the issue
can still happen for other reasons (as in your case).


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-12-01 17:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 15:26 [Qemu-devel] [PATCH v2] exec.c: Fix subpage memory access to RAM MemoryRegion Andreas Färber
2011-12-01  9:29 ` Avi Kivity
2011-12-01  9:37   ` Gleb Natapov
2011-12-01  9:41     ` Avi Kivity
2011-12-01  9:47       ` Gleb Natapov
2011-12-01  9:54         ` Avi Kivity
2011-12-01 10:06           ` Gleb Natapov
2011-12-01 17:18             ` Andreas Färber
2011-12-01 17:24               ` Avi Kivity [this message]
2011-12-09 12:32   ` Andreas Färber
2011-12-11  9:51 ` Avi Kivity
2011-12-15 18:09 ` Anthony Liguori
2012-08-22 16:53   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED7B83E.3080300@redhat.com \
    --to=avi@redhat.com \
    --cc=afaerber@suse.de \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).