From: "Arend van Spriel" <arend@broadcom.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: "ryanh@linux.vnet.ibm.com" <ryanh@linux.vnet.ibm.com>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Guest stop notification
Date: Thu, 1 Dec 2011 18:31:56 +0100 [thread overview]
Message-ID: <4ED7BA0C.5060702@broadcom.com> (raw)
In-Reply-To: <20111201171938.GA8803@mgebm.net>
On 12/01/2011 06:19 PM, Eric B Munson wrote:
> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>
>> On 2011-11-29 22:36, Eric B Munson wrote:
>>> +
>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>> {
>>> CPUState *env = opaque;
>>>
>>> if (running) {
>>> env->tsc_valid = false;
>>> + kvm_put_guest_paused(env);
>>
>> checkpatch.pl would have asked you to remove this tab.
>
> Will change to spaces for V2.
>
Huh. Remove what tab? Indent are always 8-space TAB according
CodingStyle doc:
Chapter 1: Indentation
Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3.
Gr. AvS
next prev parent reply other threads:[~2011-12-01 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 21:36 [Qemu-devel] [PATCH] Guest stop notification Eric B Munson
2011-11-29 22:10 ` Anthony Liguori
2011-12-01 14:37 ` Jan Kiszka
2011-12-01 17:19 ` Eric B Munson
2011-12-01 17:31 ` Arend van Spriel [this message]
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 21:22 ` Marcelo Tosatti
2011-12-01 17:22 ` Eric B Munson
2011-12-01 17:36 ` Jan Kiszka
2011-12-01 21:25 ` Marcelo Tosatti
2011-12-01 21:32 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED7BA0C.5060702@broadcom.com \
--to=arend@broadcom.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).