From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arend@broadcom.com>) id 1RWAy1-0000vM-Fo
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 13:02:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arend@broadcom.com>) id 1RWAxx-0006uH-CI
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 13:02:41 -0500
Received: from mms1.broadcom.com ([216.31.210.17]:1384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arend@broadcom.com>) id 1RWAxx-0006u3-5N
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 13:02:37 -0500
Message-ID: <4ED7BA0C.5060702@broadcom.com>
Date: Thu, 1 Dec 2011 18:31:56 +0100
From: "Arend van Spriel" <arend@broadcom.com>
MIME-Version: 1.0
References: <1322602574-27072-1-git-send-email-emunson@mgebm.net>
	<4ED79138.60603@siemens.com> <20111201171938.GA8803@mgebm.net>
In-Reply-To: <20111201171938.GA8803@mgebm.net>
Content-Type: text/plain;
 charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Guest stop notification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric B Munson <emunson@mgebm.net>
Cc: "ryanh@linux.vnet.ibm.com" <ryanh@linux.vnet.ibm.com>, "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>, "mtosatti@redhat.com" <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "avi@redhat.com" <avi@redhat.com>

On 12/01/2011 06:19 PM, Eric B Munson wrote:
> On Thu, 01 Dec 2011, Jan Kiszka wrote:
> 
>> On 2011-11-29 22:36, Eric B Munson wrote:
>>> +
>>>  static void cpu_update_state(void *opaque, int running, RunState state)
>>>  {
>>>      CPUState *env = opaque;
>>>  
>>>      if (running) {
>>>          env->tsc_valid = false;
>>> +	kvm_put_guest_paused(env);
>>
>> checkpatch.pl would have asked you to remove this tab.
> 
> Will change to spaces for V2.
> 

Huh. Remove what tab? Indent are always 8-space TAB according
CodingStyle doc:

                Chapter 1: Indentation

Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3.


Gr. AvS