From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wudxw@linux.vnet.ibm.com>) id 1RWK6H-00068Q-Li
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 22:47:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wudxw@linux.vnet.ibm.com>) id 1RWK6E-0006zg-T9
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 22:47:49 -0500
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:50681)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wudxw@linux.vnet.ibm.com>) id 1RWK6E-0006yu-7R
	for qemu-devel@nongnu.org; Thu, 01 Dec 2011 22:47:46 -0500
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <wudxw@linux.vnet.ibm.com>;
	Fri, 2 Dec 2011 09:17:40 +0530
Message-ID: <4ED84A55.5060106@linux.vnet.ibm.com>
Date: Fri, 02 Dec 2011 11:47:33 +0800
From: Mark Wu <wudxw@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1322796212-324-1-git-send-email-zhihuili@linux.vnet.ibm.com>
In-Reply-To: <1322796212-324-1-git-send-email-zhihuili@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Zhi Hui <zhihuili@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 12/02/2011 11:23 AM, Li Zhi Hui wrote:
> Signed-off-by: Li Zhi Hui<zhihuili@linux.vnet.ibm.com>
> ---
>   hw/smbus_eeprom.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c
> index 5d080ab..d66fbbc 100644
> --- a/hw/smbus_eeprom.c
> +++ b/hw/smbus_eeprom.c
> @@ -142,4 +142,5 @@ void smbus_eeprom_init(i2c_bus *smbus, int nb_eeprom,
>           qdev_prop_set_ptr(eeprom, "data", eeprom_buf + (i * 256));
>           qdev_init_nofail(eeprom);
>       }
> +    g_free(eeprom_buf);
>   }
The memory pointed by eeprom_buf is used as 'data' buf of 8 
SMBusEEPROMDevice after initialization.  And it calls qdev_init_nofail, 
which will exit on failure. it should be ok to leave it there. Anyway, 
you shouldn't free it in the initialization.

Mark.