qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhi Hui Li <zhihuili@linux.vnet.ibm.com>
To: Mark Wu <wudxw@linux.vnet.ibm.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	QEMU-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak
Date: Fri, 02 Dec 2011 13:41:55 +0800	[thread overview]
Message-ID: <4ED86523.2000801@linux.vnet.ibm.com> (raw)
In-Reply-To: <4ED84A55.5060106@linux.vnet.ibm.com>

On 2011年12月02日 11:47, Mark Wu wrote:
> On 12/02/2011 11:23 AM, Li Zhi Hui wrote:
>> Signed-off-by: Li Zhi Hui<zhihuili@linux.vnet.ibm.com>
>> ---
>> hw/smbus_eeprom.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/smbus_eeprom.c b/hw/smbus_eeprom.c
>> index 5d080ab..d66fbbc 100644
>> --- a/hw/smbus_eeprom.c
>> +++ b/hw/smbus_eeprom.c
>> @@ -142,4 +142,5 @@ void smbus_eeprom_init(i2c_bus *smbus, int nb_eeprom,
>> qdev_prop_set_ptr(eeprom, "data", eeprom_buf + (i * 256));
>> qdev_init_nofail(eeprom);
>> }
>> + g_free(eeprom_buf);
>> }
> The memory pointed by eeprom_buf is used as 'data' buf of 8
> SMBusEEPROMDevice after initialization. And it calls qdev_init_nofail,
> which will exit on failure. it should be ok to leave it there. Anyway,
> you shouldn't free it in the initialization.
>
> Mark.
>
>
I'm afraid I was too fast when I sent a patch with memory leak, and 
don't look it carefully , It was a pointer to a pointer.

I agree with Mark Wu.

      reply	other threads:[~2011-12-02  5:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02  3:23 [Qemu-devel] [PATCH] hw/smbus_eeprom.c : fix memory leak Li Zhi Hui
2011-12-02  3:47 ` Mark Wu
2011-12-02  5:41   ` Zhi Hui Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED86523.2000801@linux.vnet.ibm.com \
    --to=zhihuili@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wudxw@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).