From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWRyn-0004Kl-9F for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:12:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWRyj-0003Qb-BB for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:12:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWRyj-0003QX-3T for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:12:33 -0500 Message-ID: <4ED8C16A.9090703@redhat.com> Date: Fri, 02 Dec 2011 13:15:38 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com> <1322687028-29714-8-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1322687028-29714-8-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/18] qom: add link properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Stefan Hajnoczi , Jan Kiszka , Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino Am 30.11.2011 22:03, schrieb Anthony Liguori: > Links represent an ephemeral relationship between devices. They are meant to > replace the qdev concept of busses by allowing more informal relationships > between devices. > > Links are fairly limited in their usefulness without implementing QOM-style > subclassing and interfaces. > > Signed-off-by: Anthony Liguori Same thing as in the previous patch: The code doesn't seem to be prepared for the case that the "child" (this is not a tree, so there are no children...) is removed. While you could say that devices used for composition just shouldn't be unpluggable, I don't think you can require this for links. Kevin