From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RWS5k-0006C5-G3
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:19:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RWS5j-0005jz-GP
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:19:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58783)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RWS5j-0005jt-8c
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 07:19:47 -0500
Message-ID: <4ED8C25C.5060105@redhat.com>
Date: Fri, 02 Dec 2011 13:19:40 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>	<1322687028-29714-3-git-send-email-aliguori@us.ibm.com>
	<4ED7A276.4080803@redhat.com> <4ED823D7.3030207@codemonkey.ws>
In-Reply-To: <4ED823D7.3030207@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/18] qom: register legacy properties as
 new	style properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

  Hi,

>>> +        prop->info->print(dev, prop, buffer, sizeof(buffer));
>>> +        visit_type_str(v,&ptr, name, errp);
>>
>> I think you can look at prop->info->type here and do something more
>> clever at least for the bool + integer properties.
> 
> That might get a little tough because I want legacy<> types to be
> handled as strings.  I guess we could promote bool/int to non-legacy types.

Indeed.  For chardev and drive properties which will be some kind of
link<..> in the new world (correct?) it probably makes sense to keep
them as legacy<...>.

While being at it:  bus properties might need some more thinking here
too.  Partly they are used for physical addressing, so they will be
replaced by link<...> too I guess?  Some of them have special parsing
and will end up in legacy<...> anyway.  Some are plain integers though
(hda for example) ...

cheers,
  Gerd