From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35238)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUY3-0003po-1I
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 09:57:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUXx-0004zL-3y
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 09:57:10 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:43671)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUXw-0004z7-U3
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 09:57:04 -0500
Received: by ywe9 with SMTP id 9so3755156ywe.4
	for <qemu-devel@nongnu.org>; Fri, 02 Dec 2011 06:57:04 -0800 (PST)
Message-ID: <4ED8E73D.5020102@codemonkey.ws>
Date: Fri, 02 Dec 2011 08:57:01 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>	<1322687028-29714-8-git-send-email-aliguori@us.ibm.com>
	<4ED8C16A.9090703@redhat.com>
In-Reply-To: <4ED8C16A.9090703@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/18] qom: add link properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>

On 12/02/2011 06:15 AM, Kevin Wolf wrote:
> Am 30.11.2011 22:03, schrieb Anthony Liguori:
>> Links represent an ephemeral relationship between devices.  They are meant to
>> replace the qdev concept of busses by allowing more informal relationships
>> between devices.
>>
>> Links are fairly limited in their usefulness without implementing QOM-style
>> subclassing and interfaces.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> Same thing as in the previous patch: The code doesn't seem to be
> prepared for the case that the "child" (this is not a tree, so there are
> no children...) is removed. While you could say that devices used for
> composition just shouldn't be unpluggable, I don't think you can require
> this for links.

I think we need reference counts to handle this appropriately.

Regards,

Anthony Liguori

>
> Kevin
>