From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUpk-0005Yp-Jl
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 10:15:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUpj-0000Bq-J0
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 10:15:28 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:50219)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RWUpj-0000Bf-DY
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 10:15:27 -0500
Received: by iakk32 with SMTP id k32so5042541iak.4
	for <qemu-devel@nongnu.org>; Fri, 02 Dec 2011 07:15:26 -0800 (PST)
Message-ID: <4ED8EB8B.9090800@codemonkey.ws>
Date: Fri, 02 Dec 2011 09:15:23 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4ED8DF02.5060605@redhat.com> <4ED8E5A3.2080909@codemonkey.ws>
	<20111202150850.GJ2274323@orkuz.home>
In-Reply-To: <20111202150850.GJ2274323@orkuz.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] libvirt doesn't work with qemu 1.0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, libvir-list@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 12/02/2011 09:08 AM, Jiri Denemark wrote:
> On Fri, Dec 02, 2011 at 08:50:11 -0600, Anthony Liguori wrote:
>> On 12/02/2011 08:21 AM, Gerd Hoffmann wrote:
>>>     Hi,
>>>
>>> $subject says all.  The error message is:
>>>
>>> error: internal error cannot parse /home/kraxel/bin/qemu-default version
>>> number in 'QEMU emulator version 1.0, Copyright (c) 2003-2008 Fabrice
>>> Bellard'
>>
>> Parsing help output for the version number is a really bad idea.  query-version
>> in QMP does the right thing:
>>
>> (QEMU) query-version
>> {u'return': {u'qemu': {u'micro': 0, u'major': 1, u'minor': 0}, u'package': ''}}
>
> Which of course only works with new enough QEMU that is known to support QMP
> (which BTW we detect by checking the version number).

Or you could just try the -qmp option and if QEMU exits, it doesn't support it. 
  That's going to be a lot more reliable than checking a version number.

Regards,

Anthony Liguori

> Anyway, the fix is easy,
> we just need to assume micro is 0 if it's missing instead of requiring it to
> be present. A fix will come soon.
>
> Jirka
>