[Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Hi

[ Resnd this time also ading fabrice address, sorry ]

v2:
- split patches by file, make easier to add "acked-by" notices.
- cc'd fabrice
- everybody (except for Thiemo for ovbious reasons) answered.
- move ppc/sparc/i386 to BSD like license from vl.c at Blue
  suggestion. 

- move all other licenses to GPL v2 or later (notice that I had forget
  the later part on the 1st submission).  Notice this change for the
  people that acked previous version.

Any other comments?

v1:

This patch adds copyrights to all the machine description files for
all architectures supported. (this is done on top of my vmstate-cpus
series patches) The problem?

- What should we put as "copyirght" owners.

Althought I modified almost every line of the files, mostly of the
changes are a conversion, so claiming myself as the only "copyright"
owner sounds at least pretentious, and more than probably false.

I tried to "dig" into the git logs and tried to came with "whoever"
commit the initial cpu_save/load foar each architecture.  I have put
them as:

 * Based on qemu-file support done by:
 *   Richard Henderson <rth@twiddle.net>

But I would preffer that the persons involved state what copyright
notice they want, name, address, year(s), etc.  (Some architectures
already have a propper copyright notice, I didn't touch them), and
others had an empty file (I put mine there on the previosu series).

Several of the logs are from the svn days, and then I don't know if
the person was the committer, or the author.  If anyone contributed
to the functionality and want to add its copyright, please told me.

To make things more complicated, when machine.c files were split from
vl.c, they didn't carry any copyright notice at all, should we copy
back everything from vl.c?

To make things more complicated, it looks like Thiemo Seufer did the
original mips support, and he passed away.  So he can't obviously
comment.

Anthony asked me to send a patch to the list, asking form comments.

alpha:
CC: Richard Henderson <rth@twiddle.net>

arm:
CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>

  (it appears as balrog, but on irc channel peter told me that balrog
  has him)

cris:
CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>

i386:

Fabrice Bellard?

 * Copyright (c) 2003-2008 Fabrice Bellard

Didn't cc'd him because he left project/didn't have email address on
MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
know.

lm32:

CC: Michael Walle <michael@walle.cc>

mips:

Thiemo Seufer?

ppc & sparc:

CC: Blue Swirl <blauwirbel@gmail.com>


What do you think, what should we do?  Juan.



*** BLURB HERE ***

Juan Quintela (8):
  vmstate: Add copyright info for alpha processor
  vmstate: Add copyright info for lm32 processor
  vmstate: Add copyright info for cris processor
  vmstate: Add copyright info for arm processor
  vmstate: Add copyright info for i386 processor
  vmstate: Add copyright info for mips processor
  vmstate: Add copyright info for ppc processor
  vmstate: Add copyright info for sparc processor

 target-alpha/vmstate-cpu.c |   15 +++++++++++++++
 target-arm/vmstate-cpu.c   |   15 +++++++++++++++
 target-cris/vmstate-cpu.c  |   15 +++++++++++++++
 target-i386/vmstate-cpu.c  |   28 ++++++++++++++++++++++++++++
 target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
 target-mips/vmstate-cpu.c  |   29 +++++++++++++++++++++++++++++
 target-ppc/vmstate-cpu.c   |   28 ++++++++++++++++++++++++++++
 target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
 8 files changed, 174 insertions(+), 0 deletions(-)

-- 
1.7.7.1

[Qemu-devel] [PATCH 1/8] vmstate: Add copyright info for alpha processor

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Richard Henderson <rth@twiddle.net>
---
 target-alpha/vmstate-cpu.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/target-alpha/vmstate-cpu.c b/target-alpha/vmstate-cpu.c
index 156cb74..9d4b065 100644
--- a/target-alpha/vmstate-cpu.c
+++ b/target-alpha/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for alpha cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *   Richard Henderson <rth@twiddle.net>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or
+ * later.  See the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static int get_fpcr(QEMUFile *f, void *opaque, size_t size)
-- 
1.7.7.1

[Qemu-devel] [PATCH 2/8] vmstate: Add copyright info for lm32 processor

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-By: Michael Walle <michael@walle.cc>
---
 target-lm32/vmstate-cpu.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c
index 60b4b29..27e09d2 100644
--- a/target-lm32/vmstate-cpu.c
+++ b/target-lm32/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for lm32 cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Michael Walle <michael@walle.cc>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or
+ * later.  See the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 const VMStateDescription vmstate_cpu = {
-- 
1.7.7.1

[Qemu-devel] [PATCH 3/8] vmstate: Add copyright info for cris processor

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---
 target-cris/vmstate-cpu.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c
index 0f732d3..f062272 100644
--- a/target-cris/vmstate-cpu.c
+++ b/target-cris/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for cris cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Edgar E. Iglesias <edgar.iglesias@gmail.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or
+ * later.  See the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tlbset = {
-- 
1.7.7.1

[Qemu-devel] [PATCH 4/8] vmstate: Add copyright info for arm processor

[Juan Quintela]

Signed-off-by: Juan Quintela <quintela@redhat.com>
Acked-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
---
 target-arm/vmstate-cpu.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/target-arm/vmstate-cpu.c b/target-arm/vmstate-cpu.c
index 836d9ed..bc48434 100644
--- a/target-arm/vmstate-cpu.c
+++ b/target-arm/vmstate-cpu.c
@@ -1,3 +1,18 @@
+/*
+ * Migration support for arm cpus
+ *
+ * Copyright (C) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Based on qemu-file support done by:
+ *  Andrzej Zaborowski <andrew.zaborowski@intel.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or
+ * later.  See the COPYING file in the top-level directory.
+ */
+
 #include "hw/hw.h"

 static bool feature_vfp_needed(void *opaque)
-- 
1.7.7.1

[Qemu-devel] [PATCH 5/8] vmstate: Add copyright info for i386 processor

[Juan Quintela]

v2: Move license to BSD-like as in vl.c
    Add Fabrice copyright from vl.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 target-i386/vmstate-cpu.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/target-i386/vmstate-cpu.c b/target-i386/vmstate-cpu.c
index 838983e..442a1f0 100644
--- a/target-i386/vmstate-cpu.c
+++ b/target-i386/vmstate-cpu.c
@@ -1,3 +1,31 @@
+/*
+ * Migration support for x86 cpu
+ *
+ * Copyright (c) 2003-2008 Fabrice Bellard
+ * Copyright (c) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_segment = {
-- 
1.7.7.1

[Qemu-devel] [PATCH 6/8] vmstate: Add copyright info for mips processor

[Juan Quintela]

v2: Move license to BSD-like as in vl.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 target-mips/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/target-mips/vmstate-cpu.c b/target-mips/vmstate-cpu.c
index d6d7830..f709cf2 100644
--- a/target-mips/vmstate-cpu.c
+++ b/target-mips/vmstate-cpu.c
@@ -1,3 +1,32 @@
+/*
+ * Migration support for mips cpu
+ *
+ * Copyright (c) 2003-2008 Fabrice Bellard
+ * Copyright (c) 2003-2008 Thiemo Seufer
+ * Copyright (c) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tc = {
-- 
1.7.7.1

[Qemu-devel] [PATCH 7/8] vmstate: Add copyright info for ppc processor

[Juan Quintela]

v2: Move license to BSD-like as in vl.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 target-ppc/vmstate-cpu.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c
index 1664d32..9e36a18 100644
--- a/target-ppc/vmstate-cpu.c
+++ b/target-ppc/vmstate-cpu.c
@@ -1,3 +1,31 @@
+/*
+ * Migration support for ppc cpu
+ *
+ * Copyright (c) 2003-2011 Blue Swirl <blauwirbel@gmail.com>
+ * Copyright (c) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_tlb = {
-- 
1.7.7.1

[Qemu-devel] [PATCH 8/8] vmstate: Add copyright info for sparc processor

[Juan Quintela]

v2: Move license to BSD-like as in vl.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)

diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
index 259db19..c74ea9a 100644
--- a/target-sparc/vmstate-cpu.c
+++ b/target-sparc/vmstate-cpu.c
@@ -1,3 +1,32 @@
+/*
+ * Migration support for sparc cpu
+ *
+ * Copyright (c) 2003-2008 Fabrice Bellard
+ * Copyright (c) 2003-2011 Blue Swirl <blauwirbel@gmail.com>
+ * Copyright (c) 2011 Red Hat, Inc.
+ *
+ * Author(s):
+ *  Juan Quintela <quintela@redhat.com>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
 #include "hw/hw.h"

 static const VMStateDescription vmstate_cpu_timer = {
-- 
1.7.7.1

Re: [Qemu-devel] [PATCH 7/8] vmstate: Add copyright info for ppc processor

[Blue Swirl]

On Wed, Nov 23, 2011 at 15:44, Juan Quintela <quintela@redhat.com> wrote:
> v2: Move license to BSD-like as in vl.c
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  target-ppc/vmstate-cpu.c |   28 ++++++++++++++++++++++++++++
>  1 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/target-ppc/vmstate-cpu.c b/target-ppc/vmstate-cpu.c
> index 1664d32..9e36a18 100644
> --- a/target-ppc/vmstate-cpu.c
> +++ b/target-ppc/vmstate-cpu.c
> @@ -1,3 +1,31 @@
> +/*
> + * Migration support for ppc cpu
> + *
> + * Copyright (c) 2003-2011 Blue Swirl <blauwirbel@gmail.com>

This is not correct either. I started hacking QEMU in 2004 earliest
and my latest commit to target-ppc/machine.c was in 2009, but between
those years there were only a few commits by me to these parts.
Actually the first dummy versions of PPC CPU save/load were in SVN
R772 attributed to Jocelyn Mayer. I'd drop the copyright stuff unless
it's really based on facts.

> + * Copyright (c) 2011 Red Hat, Inc.
> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_tlb = {
> --
> 1.7.7.1
>
>

Re: [Qemu-devel] [PATCH 8/8] vmstate: Add copyright info for sparc processor

[Blue Swirl]

On Wed, Nov 23, 2011 at 15:44, Juan Quintela <quintela@redhat.com> wrote:
> v2: Move license to BSD-like as in vl.c

This does not belong to the commit message.

> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
>  1 files changed, 29 insertions(+), 0 deletions(-)
>
> diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
> index 259db19..c74ea9a 100644
> --- a/target-sparc/vmstate-cpu.c
> +++ b/target-sparc/vmstate-cpu.c
> @@ -1,3 +1,32 @@
> +/*
> + * Migration support for sparc cpu
> + *
> + * Copyright (c) 2003-2008 Fabrice Bellard
> + * Copyright (c) 2003-2011 Blue Swirl <blauwirbel@gmail.com>

I'd use 2004 here.

> + * Copyright (c) 2011 Red Hat, Inc.

The above list is by no means exhaustive, at least Richard Henderson,
Igor Kovalenko and Anthony Liguori are also listed in git log for
target-sparc/machine.c. Again, either drop the copyright stuff or use
real facts. Is this even useful?

> + *
> + * Author(s):
> + *  Juan Quintela <quintela@redhat.com>
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */
> +
>  #include "hw/hw.h"
>
>  static const VMStateDescription vmstate_cpu_timer = {
> --
> 1.7.7.1
>
>

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Hi Juan,

Am 23.11.2011 16:44, schrieb Juan Quintela:
> [ Resnd this time also ading fabrice address, sorry ]
> 
> v2:
> - split patches by file, make easier to add "acked-by" notices.
> - cc'd fabrice
> - everybody (except for Thiemo for ovbious reasons) answered.
> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>   suggestion. 
> 
> - move all other licenses to GPL v2 or later (notice that I had forget
>   the later part on the 1st submission).  Notice this change for the
>   people that acked previous version.
> 
> Any other comments?

I did have another comment regarding the "Based on" part that you
haven't responded to yet.

Andreas

> 
> v1:
> 
> This patch adds copyrights to all the machine description files for
> all architectures supported. (this is done on top of my vmstate-cpus
> series patches) The problem?
> 
> - What should we put as "copyirght" owners.
> 
> Althought I modified almost every line of the files, mostly of the
> changes are a conversion, so claiming myself as the only "copyright"
> owner sounds at least pretentious, and more than probably false.
> 
> I tried to "dig" into the git logs and tried to came with "whoever"
> commit the initial cpu_save/load foar each architecture.  I have put
> them as:
> 
>  * Based on qemu-file support done by:
>  *   Richard Henderson <rth@twiddle.net>
> 
> But I would preffer that the persons involved state what copyright
> notice they want, name, address, year(s), etc.  (Some architectures
> already have a propper copyright notice, I didn't touch them), and
> others had an empty file (I put mine there on the previosu series).
> 
> Several of the logs are from the svn days, and then I don't know if
> the person was the committer, or the author.  If anyone contributed
> to the functionality and want to add its copyright, please told me.
> 
> To make things more complicated, when machine.c files were split from
> vl.c, they didn't carry any copyright notice at all, should we copy
> back everything from vl.c?
> 
> To make things more complicated, it looks like Thiemo Seufer did the
> original mips support, and he passed away.  So he can't obviously
> comment.
> 
> Anthony asked me to send a patch to the list, asking form comments.
> 
> alpha:
> CC: Richard Henderson <rth@twiddle.net>
> 
> arm:
> CC: Andrzej Zaborowski <andrew.zaborowski@intel.com>
> 
>   (it appears as balrog, but on irc channel peter told me that balrog
>   has him)
> 
> cris:
> CC: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 
> i386:
> 
> Fabrice Bellard?
> 
>  * Copyright (c) 2003-2008 Fabrice Bellard
> 
> Didn't cc'd him because he left project/didn't have email address on
> MAINTAINERS/vl.c.  If you think that I should cc'd to him, just let me
> know.
> 
> lm32:
> 
> CC: Michael Walle <michael@walle.cc>
> 
> mips:
> 
> Thiemo Seufer?
> 
> ppc & sparc:
> 
> CC: Blue Swirl <blauwirbel@gmail.com>
> 
> 
> What do you think, what should we do?  Juan.
> 
> 
> 
> *** BLURB HERE ***
> 
> Juan Quintela (8):
>   vmstate: Add copyright info for alpha processor
>   vmstate: Add copyright info for lm32 processor
>   vmstate: Add copyright info for cris processor
>   vmstate: Add copyright info for arm processor
>   vmstate: Add copyright info for i386 processor
>   vmstate: Add copyright info for mips processor
>   vmstate: Add copyright info for ppc processor
>   vmstate: Add copyright info for sparc processor
> 
>  target-alpha/vmstate-cpu.c |   15 +++++++++++++++
>  target-arm/vmstate-cpu.c   |   15 +++++++++++++++
>  target-cris/vmstate-cpu.c  |   15 +++++++++++++++
>  target-i386/vmstate-cpu.c  |   28 ++++++++++++++++++++++++++++
>  target-lm32/vmstate-cpu.c  |   15 +++++++++++++++
>  target-mips/vmstate-cpu.c  |   29 +++++++++++++++++++++++++++++
>  target-ppc/vmstate-cpu.c   |   28 ++++++++++++++++++++++++++++
>  target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
>  8 files changed, 174 insertions(+), 0 deletions(-)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 8/8] vmstate: Add copyright info for sparc processor

[Juan Quintela]

Blue Swirl <blauwirbel@gmail.com> wrote:
> On Wed, Nov 23, 2011 at 15:44, Juan Quintela <quintela@redhat.com> wrote:
>> v2: Move license to BSD-like as in vl.c
>
> This does not belong to the commit message.
>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  target-sparc/vmstate-cpu.c |   29 +++++++++++++++++++++++++++++
>>  1 files changed, 29 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-sparc/vmstate-cpu.c b/target-sparc/vmstate-cpu.c
>> index 259db19..c74ea9a 100644
>> --- a/target-sparc/vmstate-cpu.c
>> +++ b/target-sparc/vmstate-cpu.c
>> @@ -1,3 +1,32 @@
>> +/*
>> + * Migration support for sparc cpu
>> + *
>> + * Copyright (c) 2003-2008 Fabrice Bellard
>> + * Copyright (c) 2003-2011 Blue Swirl <blauwirbel@gmail.com>
>
> I'd use 2004 here.
>
>> + * Copyright (c) 2011 Red Hat, Inc.
>
> The above list is by no means exhaustive, at least Richard Henderson,
> Igor Kovalenko and Anthony Liguori are also listed in git log for
> target-sparc/machine.c. Again, either drop the copyright stuff or use
> real facts. Is this even useful?

Anthony asked me to put copyright notes on the files.  It is supposed
that every file should have a copyright notice.

As stated on the 0/8 patch, I am not happy with either:
- Assigning copyright only to me (although I changed almost every line
  of the files, almost all changes are kind of automatic)
- Put copyright notices for other people, as I have no clue about what
  name/company/years to put there.  Notice that for contributors that
  only do small changes, normally they don't care.

Add to this that:
- Anthony want every file to have a copyright notice.

This is the reason that I started with:
- Add myself as a copyright owner
- Put the original authors as: Based on previous work from: John Smith.

That makes everybody "kind of happy" (as in the film: the less of all
evils).  As you can see, everybody except yourself gave his "Acked-by".
I thought that this change was what you had in mind.  I would include
whatever text that you told me that you want to include instead.

First of all, notice that I am not a lawyer.  My understanding of
Anthony request, is that every file has to had a copyright notice.  But
not everybody that has contributed to the file has to add its copyright
(notice for example that vl.c only has a copyright notice from Fabrice,
when a lot of people has contributed to that file).

The problem here is that we are adding the copyrights after the file
exist, and then we don't have the "initial" copyright notice, that
anyone can add his/her name to it (if that is his/her wish).

Anthony also wanted this process to be very public for obvious reasons
and that everybody that has stakes on this could make any comment they
want.

If the problem is that my name is on there, just let me know and I would
remove it (the only reason that I put mine there is that I am more
comfortable adding mine that the name of anyone else, but if "anyone
else" appears and says that copyright is their, I would just include his
notice and let that alone).

I hope that I had made the reasons clear of this exercise.

Later, Juan.

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Andreas Färber <afaerber@suse.de> wrote:
> Hi Juan,
>
> Am 23.11.2011 16:44, schrieb Juan Quintela:
>> [ Resnd this time also ading fabrice address, sorry ]
>> 
>> v2:
>> - split patches by file, make easier to add "acked-by" notices.
>> - cc'd fabrice
>> - everybody (except for Thiemo for ovbious reasons) answered.
>> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>>   suggestion. 
>> 
>> - move all other licenses to GPL v2 or later (notice that I had forget
>>   the later part on the 1st submission).  Notice this change for the
>>   people that acked previous version.
>> 
>> Any other comments?
>
> I did have another comment regarding the "Based on" part that you
> haven't responded to yet.

Sorry, forgot about that one.  What text do you propose?

* Based on serialization based on QEMUFile done by:

????

Any other proposal?

Later, Juan.

Re: [Qemu-devel] [PATCH 8/8] vmstate: Add copyright info for sparc processor

[Paolo Bonzini]

On 11/27/2011 02:26 PM, Juan Quintela wrote:
>
> This is the reason that I started with:
> - Add myself as a copyright owner
> - Put the original authors as: Based on previous work from: John Smith.

I would just put Copyright (C) XXXX-YYYY The QEMU Contributors.  For a 
full list, there is always the VCS log.

Paolo

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Am 27.11.2011 14:30, schrieb Juan Quintela:
> Andreas Färber <afaerber@suse.de> wrote:
>> Hi Juan,
>>
>> Am 23.11.2011 16:44, schrieb Juan Quintela:
>>> [ Resnd this time also ading fabrice address, sorry ]
>>>
>>> v2:
>>> - split patches by file, make easier to add "acked-by" notices.
>>> - cc'd fabrice
>>> - everybody (except for Thiemo for ovbious reasons) answered.
>>> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>>>   suggestion. 
>>>
>>> - move all other licenses to GPL v2 or later (notice that I had forget
>>>   the later part on the 1st submission).  Notice this change for the
>>>   people that acked previous version.
>>>
>>> Any other comments?
>>
>> I did have another comment regarding the "Based on" part that you
>> haven't responded to yet.
> 
> Sorry, forgot about that one.  What text do you propose?
> 
> * Based on serialization based on QEMUFile done by:
> 
> ????
> 
> Any other proposal?

Keep it short and simple. Off the top of my head:

* Based on serialization code by:

(don't see what qemu-file / QEMUFile has to do with it?)

* Based on savevm code by:

(yeah, it's not just that but still a better keyword than qemu-file IMO)

But maybe I'm just misunderstanding something here?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Juan Quintela]

Andreas Färber <afaerber@suse.de> wrote:
> Am 27.11.2011 14:30, schrieb Juan Quintela:
>> Andreas Färber <afaerber@suse.de> wrote:
>>> Hi Juan,
>>>
>>> Am 23.11.2011 16:44, schrieb Juan Quintela:
>>>> [ Resnd this time also ading fabrice address, sorry ]
>>>>
>>>> v2:
>>>> - split patches by file, make easier to add "acked-by" notices.
>>>> - cc'd fabrice
>>>> - everybody (except for Thiemo for ovbious reasons) answered.
>>>> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>>>>   suggestion. 
>>>>
>>>> - move all other licenses to GPL v2 or later (notice that I had forget
>>>>   the later part on the 1st submission).  Notice this change for the
>>>>   people that acked previous version.
>>>>
>>>> Any other comments?
>>>
>>> I did have another comment regarding the "Based on" part that you
>>> haven't responded to yet.
>> 
>> Sorry, forgot about that one.  What text do you propose?
>> 
>> * Based on serialization based on QEMUFile done by:
>> 
>> ????
>> 
>> Any other proposal?
>
> Keep it short and simple. Off the top of my head:
>
> * Based on serialization code by:
>
> (don't see what qemu-file / QEMUFile has to do with it?)
>
> * Based on savevm code by:

Can we set on:

* Based on savevm serialization code by:

??

Later, Juan.

>
> (yeah, it's not just that but still a better keyword than qemu-file IMO)
>
> But maybe I'm just misunderstanding something here?
>
> Andreas

Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Am 05.12.2011 13:45, schrieb Juan Quintela:
> Andreas Färber <afaerber@suse.de> wrote:
>> Am 27.11.2011 14:30, schrieb Juan Quintela:
>>> Andreas Färber <afaerber@suse.de> wrote:
>>>> I did have another comment regarding the "Based on" part that you
>>>> haven't responded to yet.
>>>
>>> Sorry, forgot about that one.  What text do you propose?
>>>
>>> * Based on serialization based on QEMUFile done by:
>>>
>>> ????
>>>
>>> Any other proposal?
>>
>> Keep it short and simple. Off the top of my head:
>>
>> * Based on serialization code by:
>>
>> (don't see what qemu-file / QEMUFile has to do with it?)
>>
>> * Based on savevm code by:
> 
> Can we set on:
> 
> * Based on savevm serialization code by:

Sure, sounds okay to me.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg