From: Paolo Bonzini <pbonzini@redhat.com>
To: Chunyan Liu <cyliu@suse.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function to be used for many purposes
Date: Fri, 02 Dec 2011 17:32:39 +0100 [thread overview]
Message-ID: <4ED8FDA7.3090901@redhat.com> (raw)
In-Reply-To: <1322839676-7559-2-git-send-email-cyliu@suse.com>
On 12/02/2011 04:27 PM, Chunyan Liu wrote:
> @@ -42,6 +42,18 @@ static int verbose;
> static char *device;
> static char *srcpath;
> static char *sockpath;
> +static int is_sockpath_option;
> +static int sigterm_fd[2];
> +static off_t dev_offset;
> +static uint32_t nbdflags;
> +static bool disconnect;
> +static const char *bindto = "0.0.0.0";
> +static int port = NBD_DEFAULT_PORT;
> +static int li;
> +static int flags = BDRV_O_RDWR;
> +static int partition = -1;
> +static int shared = 1;
> +static int persistent;
A lot of statics... "li" seems unused.
I took patch 1/3 in my tree (git://github.com/bonzini/qemu.git branch
nbd-server). I'll post it together with my patches next week.
Paolo
next prev parent reply other threads:[~2011-12-02 16:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 15:27 [Qemu-devel] [PATCH v4 1/3] Update ioctl order in nbd_init() to detect EBUSY Chunyan Liu
2011-12-02 15:27 ` [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function to be used for many purposes Chunyan Liu
2011-12-02 16:32 ` Paolo Bonzini [this message]
2011-12-05 5:46 ` Chunyan Liu
2011-12-05 13:16 ` Stefan Hajnoczi
2011-12-06 6:56 ` Chunyan Liu
2011-12-06 7:59 ` Paolo Bonzini
2011-12-06 8:42 ` Chunyan Liu
2011-12-06 8:44 ` Paolo Bonzini
2011-12-06 9:01 ` Chunyan Liu
2011-12-07 4:23 ` Chunyan Liu
2011-12-07 9:44 ` Paolo Bonzini
2011-12-08 11:55 ` Stefan Hajnoczi
2011-12-09 8:31 ` Chunyan Liu
2011-12-09 9:36 ` Stefan Hajnoczi
2011-12-02 15:27 ` [Qemu-devel] [PATCH v4 3/3] Add -f option to qemu-nbd Chunyan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8FDA7.3090901@redhat.com \
--to=pbonzini@redhat.com \
--cc=cyliu@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).