From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RWW2Y-0007Im-0z
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:32:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RWW2X-0008Ai-02
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:32:45 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:50582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RWW2W-0008AT-TD
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:32:44 -0500
Received: by iakk32 with SMTP id k32so5142715iak.4
	for <qemu-devel@nongnu.org>; Fri, 02 Dec 2011 08:32:44 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4ED8FDA7.3090901@redhat.com>
Date: Fri, 02 Dec 2011 17:32:39 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1322839676-7559-1-git-send-email-cyliu@suse.com>
	<1322839676-7559-2-git-send-email-cyliu@suse.com>
In-Reply-To: <1322839676-7559-2-git-send-email-cyliu@suse.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function
 to be used for many purposes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org

On 12/02/2011 04:27 PM, Chunyan Liu wrote:
> @@ -42,6 +42,18 @@ static int verbose;
>   static char *device;
>   static char *srcpath;
>   static char *sockpath;
> +static int is_sockpath_option;
> +static int sigterm_fd[2];
> +static off_t dev_offset;
> +static uint32_t nbdflags;
> +static bool disconnect;
> +static const char *bindto = "0.0.0.0";
> +static int port = NBD_DEFAULT_PORT;
> +static int li;
> +static int flags = BDRV_O_RDWR;
> +static int partition = -1;
> +static int shared = 1;
> +static int persistent;

A lot of statics... "li" seems unused.

I took patch 1/3 in my tree (git://github.com/bonzini/qemu.git branch 
nbd-server).  I'll post it together with my patches next week.

Paolo