From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWW3Y-00080t-18 for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:33:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWW3X-0008Ln-4d for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:33:48 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:63834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWW3X-0008Lh-1M for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:33:47 -0500 Received: by iakk32 with SMTP id k32so5144409iak.4 for ; Fri, 02 Dec 2011 08:33:46 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4ED8FDE5.6080204@redhat.com> Date: Fri, 02 Dec 2011 17:33:41 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1320332422-2457-1-git-send-email-pbonzini@redhat.com> <4EB965A0.5050701@codemonkey.ws> In-Reply-To: <4EB965A0.5050701@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 11/08/2011 06:23 PM, Anthony Liguori wrote: > On 11/03/2011 10:00 AM, Paolo Bonzini wrote: >> sgabios hasn't gotten a lot of coverage since it was not shipped. For >> 1.0, >> let's disable the automatic loading of the option ROM in -nographic >> mode. We can put it back for 1.1. >> >> Signed-off-by: Paolo Bonzini > > Applied. Thanks. Can you please revert it for 1.1? Thanks! Paolo >> --- >> Requested by Anthony on IRC. >> >> hw/pc.c | 9 --------- >> 1 files changed, 0 insertions(+), 9 deletions(-) >> >> diff --git a/hw/pc.c b/hw/pc.c >> index eb4c2d8..1024465 100644 >> --- a/hw/pc.c >> +++ b/hw/pc.c >> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus) >> isa_vga_init(); >> } >> } >> - >> - /* >> - * sga does not suppress normal vga output. So a machine can have both a >> - * vga card and sga manually enabled. Output will be seen on both. >> - * For nographic case, sga is enabled at all times >> - */ >> - if (display_type == DT_NOGRAPHIC) { >> - isa_create_simple("sga"); >> - } >> } >> >> static void cpu_request_exit(void *opaque, int irq, int level) > > >