From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWW49-0000Fj-P9 for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:34:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWW48-0008VM-8Q for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:34:25 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:56809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWW48-0008VG-4e for qemu-devel@nongnu.org; Fri, 02 Dec 2011 11:34:24 -0500 Received: by iakk32 with SMTP id k32so5145458iak.4 for ; Fri, 02 Dec 2011 08:34:23 -0800 (PST) Message-ID: <4ED8FE0C.8060308@codemonkey.ws> Date: Fri, 02 Dec 2011 10:34:20 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320332422-2457-1-git-send-email-pbonzini@redhat.com> <4EB965A0.5050701@codemonkey.ws> <4ED8FDE5.6080204@redhat.com> In-Reply-To: <4ED8FDE5.6080204@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 12/02/2011 10:33 AM, Paolo Bonzini wrote: > On 11/08/2011 06:23 PM, Anthony Liguori wrote: >> On 11/03/2011 10:00 AM, Paolo Bonzini wrote: >>> sgabios hasn't gotten a lot of coverage since it was not shipped. For >>> 1.0, >>> let's disable the automatic loading of the option ROM in -nographic >>> mode. We can put it back for 1.1. >>> >>> Signed-off-by: Paolo Bonzini >> >> Applied. Thanks. > > Can you please revert it for 1.1? Thanks! Can you send a patch? Regards, Anthony Liguori > > Paolo > >>> --- >>> Requested by Anthony on IRC. >>> >>> hw/pc.c | 9 --------- >>> 1 files changed, 0 insertions(+), 9 deletions(-) >>> >>> diff --git a/hw/pc.c b/hw/pc.c >>> index eb4c2d8..1024465 100644 >>> --- a/hw/pc.c >>> +++ b/hw/pc.c >>> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus) >>> isa_vga_init(); >>> } >>> } >>> - >>> - /* >>> - * sga does not suppress normal vga output. So a machine can have both a >>> - * vga card and sga manually enabled. Output will be seen on both. >>> - * For nographic case, sga is enabled at all times >>> - */ >>> - if (display_type == DT_NOGRAPHIC) { >>> - isa_create_simple("sga"); >>> - } >>> } >>> >>> static void cpu_request_exit(void *opaque, int irq, int level) >> >> >> >