From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RWWoR-0003Vh-Bz
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 12:22:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RWWoQ-0003WA-D0
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 12:22:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RWWoQ-0003Vu-6N
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 12:22:14 -0500
Message-ID: <4ED90A02.8080901@redhat.com>
Date: Fri, 02 Dec 2011 18:25:22 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1322765012-3164-1-git-send-email-aliguori@us.ibm.com>
	<1322765012-3164-7-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1322765012-3164-7-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 6/6] Add C version of rtc-test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

Am 01.12.2011 19:43, schrieb Anthony Liguori:
> ---
>  Makefile   |    4 +
>  rtc-test.c |  201 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 205 insertions(+), 0 deletions(-)
>  create mode 100644 rtc-test.c
> 
> diff --git a/Makefile b/Makefile
> index 301c75e..838cb01 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -215,6 +215,10 @@ $(qga-obj-y) qemu-ga.o: $(QGALIB_GEN) $(GENERATED_HEADERS)
>  
>  qemu-ga$(EXESUF): qemu-ga.o $(qga-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qobject-obj-y) $(version-obj-y) $(QGALIB_OBJ)
>  
> +libqtest.o: libqtest.c

Did you forget to commit libqtest.c?

I think your series is a good start, but the examples only use port I/O.
Most other tests would probably need to access RAM (not sure if it's
convenient to do explicit read/write commands for that), interrupts and
some even QMP.

Should the framework and the tests live in the tests/ directory?

Kevin