From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWY4y-0005uG-4Q for qemu-devel@nongnu.org; Fri, 02 Dec 2011 13:43:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWY4w-0005S5-VS for qemu-devel@nongnu.org; Fri, 02 Dec 2011 13:43:24 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:33901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWY4w-0005Rz-OE for qemu-devel@nongnu.org; Fri, 02 Dec 2011 13:43:22 -0500 Received: by iakk32 with SMTP id k32so5322074iak.4 for ; Fri, 02 Dec 2011 10:43:21 -0800 (PST) Message-ID: <4ED91C46.1030804@codemonkey.ws> Date: Fri, 02 Dec 2011 12:43:18 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1322765012-3164-1-git-send-email-aliguori@us.ibm.com> <1322765012-3164-7-git-send-email-aliguori@us.ibm.com> <4ED90A02.8080901@redhat.com> <4ED90A55.4010405@codemonkey.ws> <4ED90EB7.1080300@redhat.com> In-Reply-To: <4ED90EB7.1080300@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 6/6] Add C version of rtc-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jan Kiszka , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Luiz Capitulino On 12/02/2011 11:45 AM, Kevin Wolf wrote: > Am 02.12.2011 18:26, schrieb Anthony Liguori: >> On 12/02/2011 11:25 AM, Kevin Wolf wrote: >> So that's how you read/write memory. Likewise, for IRQs, you can poll the >> status of a given IRQ. I thought about doing some sort of signal magic around >> but when writing tests, polling the IRQ seems easier to deal with. > > Okay, polling interrupts should be good enough for tests. > > I guess the test still needs to do everything that a guest OS would have > to do, for example send an EOI to the PIC? We'll probably want to have a > library for such things then, but we can add it with the first test that > uses interrupts. No, right now we more or less create a fake I/O APIC. We don't have to deal with masking in the local APIC, boot strapping, or anything like that. It makes writing tests easier but I think it makes supporting MSI a bit more challenging. I'm not sure how well it will generalize to other platforms either. That's one of the reasons I wanted to get an early version out to get some feedback on this. Regards, Anthony Liguori >>> Should the framework and the tests live in the tests/ directory? >> >> Probably, except that tests/ has it's own Makefile which is sort of awkward. >> Any objections to moving tests/* to tests/tcg-test and then moving all of the >> various gtest/check tests to tests/ along with qtest? > > No objection, I think this is exactly what we should do. > > Kevin >