qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: libvir-list@redhat.com, Gerd Hoffmann <kraxel@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [libvirt]  libvirt doesn't work with qemu 1.0
Date: Fri, 02 Dec 2011 12:29:34 -0700	[thread overview]
Message-ID: <4ED9271E.7020800@redhat.com> (raw)
In-Reply-To: <4ED8EB8B.9090800@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

On 12/02/2011 08:15 AM, Anthony Liguori wrote:
>> Which of course only works with new enough QEMU that is known to
>> support QMP
>> (which BTW we detect by checking the version number).
> 
> Or you could just try the -qmp option and if QEMU exits, it doesn't
> support it.  That's going to be a lot more reliable than checking a
> version number.

But we already have to call 'qemu -h' for other reasons; so we might as
well be efficient and learn as much as possible from that result than by
calling both 'qemu -h' and 'qemu -qmp ...', in order to probe what qemu
supports.

Also, 'qemu -qmp' doesn't work.  What's the proper syntax for invoking
qemu in order to query QMP capabilities, but without also starting up a
guest?

At any rate, yes, we want to improve libvirt to cache qemu capabilities,
to do the probing once at startup and then again any time the mtime of
the qemu binary changes, rather than the current policy of doing it on
every VM startup; once we cache information, making multiple probes will
still be more efficient in the long ran than the current probe per guest.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

  reply	other threads:[~2011-12-02 19:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02 14:21 [Qemu-devel] libvirt doesn't work with qemu 1.0 Gerd Hoffmann
2011-12-02 14:50 ` Anthony Liguori
2011-12-02 15:08   ` Jiri Denemark
2011-12-02 15:15     ` Anthony Liguori
2011-12-02 19:29       ` Eric Blake [this message]
2011-12-02 20:32         ` [Qemu-devel] [libvirt] " Anthony Liguori
2012-01-26  3:55           ` Eric Blake
2012-01-26  9:41             ` Paolo Bonzini
2012-01-26 10:55               ` Markus Armbruster
2012-01-26 12:46               ` Eric Blake
2012-01-26 13:00                 ` Paolo Bonzini
2012-01-26 19:23             ` Luiz Capitulino
2011-12-02 18:53 ` Dave Allan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED9271E.7020800@redhat.com \
    --to=eblake@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).