From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RWa6M-00079C-1O
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 15:52:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RWa6L-0005xJ-28
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 15:52:57 -0500
Received: from e31.co.us.ibm.com ([32.97.110.149]:48677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1RWa6K-0005x9-TC
	for qemu-devel@nongnu.org; Fri, 02 Dec 2011 15:52:57 -0500
Received: from /spool/local
	by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Fri, 2 Dec 2011 13:52:55 -0700
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pB2Kqn8g091002
	for <qemu-devel@nongnu.org>; Fri, 2 Dec 2011 13:52:50 -0700
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id pB2Kqkgi019632
	for <qemu-devel@nongnu.org>; Fri, 2 Dec 2011 13:52:46 -0700
Message-ID: <4ED93A9D.6010702@linux.vnet.ibm.com>
Date: Fri, 02 Dec 2011 15:52:45 -0500
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <4ED93037.7070902@linux.vnet.ibm.com> <4ED935D3.5040207@redhat.com>
In-Reply-To: <4ED935D3.5040207@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Adapt libvirt's Qemu version parser for
 Qemu 1.0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: libvirt <libvir-list@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 12/02/2011 03:32 PM, Eric Blake wrote:
> On 12/02/2011 01:08 PM, Stefan Berger wrote:
>> Qemu 1.0 does not show a micro version like 0.15.50 did. Adapt the
>> Qemu version parser to handle this.
>>
>> ---
>>   src/qemu/qemu_capabilities.c |   11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
> While this solves the problem, I prefer Jirka's version as being more
> complete.  NACK.
>
No problem.
What's unfortunate about it is that the parser was not flexible to 
handle it, thus 0.9.8 will presumably be the first version to accept 
Qemu 1.0.

     Stefan