From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWn7D-0006Pg-Mf for qemu-devel@nongnu.org; Sat, 03 Dec 2011 05:46:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWn7C-000789-Ry for qemu-devel@nongnu.org; Sat, 03 Dec 2011 05:46:43 -0500 Received: from fmmailgate05.web.de ([217.72.192.243]:64638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWn7C-000784-Gk for qemu-devel@nongnu.org; Sat, 03 Dec 2011 05:46:42 -0500 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate05.web.de (Postfix) with ESMTP id CE3F567B5D8D for ; Sat, 3 Dec 2011 11:46:40 +0100 (CET) Message-ID: <4ED9FE09.1040900@web.de> Date: Sat, 03 Dec 2011 11:46:33 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <27ef57671106d9214757df8a1d4cc28287dae07c.1321893802.git.mst@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBB695DA9485487563DD25FCB" Subject: Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cam Macdonell Cc: Blue Swirl , Alexander Graf , Anthony Liguori , qemu-devel@nongnu.org, "Michael S. Tsirkin" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB695DA9485487563DD25FCB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-03 00:34, Cam Macdonell wrote: > So I believe my bug is due to the fact the new logic included in this > patch requires msix_write_config() to be called to unmask the vectors. > Virtio-pci calls msix_write_config(), but ivshmem does not (nor does > PCIe so I'm not sure if it's also affected). msi[x]_write_config should not have to be called from device models but it must be right now. I proposed a patch a while ago to improve this. Same for msix_reset. Jan --------------enigBB695DA9485487563DD25FCB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Z/gwACgkQitSsb3rl5xS9hQCgwBhX2w0UbbnGYRY9n0a51ujg f4QAnApLmB04CbRVYF9XffaVIV7Puj99 =lH4k -----END PGP SIGNATURE----- --------------enigBB695DA9485487563DD25FCB--