[Qemu-devel] endless loop when use qemu-system-mipsel to load bios

[Qemu-devel] endless loop when use qemu-system-mipsel to load bios

[rui chen]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

Hi all,
    When I try to use command line "qemu-system-mipsel -M malta -L .
-nographic" to run redboot,  it will have an endless loop, then I find this
bug, here is my patch:


Author: Chen Rui <chennrui@gmail.com>
Date:   Sat Nov 12 01:38:23 2011 +0800

    resolve an endless loop when use qemu-system-mipsel to load bios

    Signed-off-by: Chen Rui <chennrui@gmail.com>

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index bb49749..e7dfbd6 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
             uint32_t *end = addr + bios_size;
             while (addr < end) {
                 bswap32s(addr);
+                addr++;
             }
         }
 #endif


-- 
rui chen
=======
   B.R

[-- Attachment #2: Type: text/html, Size: 982 bytes --]

Re: [Qemu-devel] endless loop when use qemu-system-mipsel to load bios

[Markus Armbruster]

rui chen <chennrui@gmail.com> writes:

> Hi all,
>     When I try to use command line "qemu-system-mipsel -M malta -L .
> -nographic" to run redboot,  it will have an endless loop, then I find this
> bug, here is my patch:
>
>
> Author: Chen Rui <chennrui@gmail.com>
> Date:   Sat Nov 12 01:38:23 2011 +0800
>
>     resolve an endless loop when use qemu-system-mipsel to load bios
>
>     Signed-off-by: Chen Rui <chennrui@gmail.com>

Please use git-format-patch, not git-show.  And please put all of the
description in the commit message.

Finally, it helps to cc: the maintainer.  scripts/get_maintainer.pl can
help find him.  For your patch, it points to Aurelien (cc'ed).

> diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> index bb49749..e7dfbd6 100644
> --- a/hw/mips_malta.c
> +++ b/hw/mips_malta.c
> @@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
>              uint32_t *end = addr + bios_size;
>              while (addr < end) {
>                  bswap32s(addr);
> +                addr++;
>              }
>          }
>  #endif

Re: [Qemu-devel] endless loop when use qemu-system-mipsel to load bios

[rui chen]

[-- Attachment #1.1: Type: text/plain, Size: 1934 bytes --]

sorry, here is my new patch file:

>From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
From: Chen Rui <chennrui@gmail.com>
Date: Sun, 13 Nov 2011 19:42:42 +0800
Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel to
load bios


Signed-off-by: Chen Rui <chennrui@gmail.com>
---
 hw/mips_malta.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index bb49749..e7dfbd6 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
             uint32_t *end = addr + bios_size;
             while (addr < end) {
                 bswap32s(addr);
+                addr++;
             }
         }
 #endif
-- 
1.7.1


2011/11/15 Markus Armbruster <armbru@redhat.com>

> rui chen <chennrui@gmail.com> writes:
>
> > Hi all,
> >     When I try to use command line "qemu-system-mipsel -M malta -L .
> > -nographic" to run redboot,  it will have an endless loop, then I find
> this
> > bug, here is my patch:
> >
> >
> > Author: Chen Rui <chennrui@gmail.com>
> > Date:   Sat Nov 12 01:38:23 2011 +0800
> >
> >     resolve an endless loop when use qemu-system-mipsel to load bios
> >
> >     Signed-off-by: Chen Rui <chennrui@gmail.com>
>
> Please use git-format-patch, not git-show.  And please put all of the
> description in the commit message.
>
> Finally, it helps to cc: the maintainer.  scripts/get_maintainer.pl can
> help find him.  For your patch, it points to Aurelien (cc'ed).
>
> > diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> > index bb49749..e7dfbd6 100644
> > --- a/hw/mips_malta.c
> > +++ b/hw/mips_malta.c
> > @@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
> >              uint32_t *end = addr + bios_size;
> >              while (addr < end) {
> >                  bswap32s(addr);
> > +                addr++;
> >              }
> >          }
> >  #endif
>

[-- Attachment #1.2: Type: text/html, Size: 2817 bytes --]

[-- Attachment #2: 0001-resolve-an-endless-loop-when-use-qemu-system-mipsel-.patch --]
[-- Type: text/x-patch, Size: 723 bytes --]

From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
From: Chen Rui <chennrui@gmail.com>
Date: Sun, 13 Nov 2011 19:42:42 +0800
Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel to load bios


Signed-off-by: Chen Rui <chennrui@gmail.com>
---
 hw/mips_malta.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index bb49749..e7dfbd6 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
             uint32_t *end = addr + bios_size;
             while (addr < end) {
                 bswap32s(addr);
+                addr++;
             }
         }
 #endif
-- 
1.7.1

Re: [Qemu-devel] endless loop when use qemu-system-mipsel to load bios

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Am 16.11.2011 16:21, schrieb rui chen:
> sorry, here is my new patch file:
>
> From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
> From: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> Date: Sun, 13 Nov 2011 19:42:42 +0800
> Subject: [PATCH] resolve an endless loop when use qemu-system-mipsel 
> to load bios
>
>
> Signed-off-by: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> ---
>  hw/mips_malta.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> index bb49749..e7dfbd6 100644
> --- a/hw/mips_malta.c
> +++ b/hw/mips_malta.c
> @@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
>              uint32_t *end = addr + bios_size;
>              while (addr < end) {
>                  bswap32s(addr);
> +                addr++;
>              }
>          }
>  #endif
> -- 
> 1.7.1

This patch fixes a regression introduced by commit
d758525180e0efff8a59cfea11f5f8348014ff6a
(More phys_ram_base elimination).

Please apply it to QEMU git master (with a modified subject, s/use/using/).

Tested-by: Stefan Weil <sw@weilnetz.de>

Regards,
Stefan Weil


[-- Attachment #2: Type: text/html, Size: 2312 bytes --]

Re: [Qemu-devel] [Qemu-trivial] endless loop when use qemu-system-mipsel to load bios

[Stefan Hajnoczi]

On Sat, Dec 03, 2011 at 11:27:29PM +0100, Stefan Weil wrote:
> Am 16.11.2011 16:21, schrieb rui chen:
> >sorry, here is my new patch file:
> >
> >From 05f4abe8d8c37f1585f2bb7cb89b15426044bb65 Mon Sep 17 00:00:00 2001
> >From: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> >Date: Sun, 13 Nov 2011 19:42:42 +0800
> >Subject: [PATCH] resolve an endless loop when use
> >qemu-system-mipsel to load bios
> >
> >
> >Signed-off-by: Chen Rui <chennrui@gmail.com <mailto:chennrui@gmail.com>>
> >---
> > hw/mips_malta.c |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/hw/mips_malta.c b/hw/mips_malta.c
> >index bb49749..e7dfbd6 100644
> >--- a/hw/mips_malta.c
> >+++ b/hw/mips_malta.c
> >@@ -911,6 +911,7 @@ void mips_malta_init (ram_addr_t ram_size,
> >             uint32_t *end = addr + bios_size;
> >             while (addr < end) {
> >                 bswap32s(addr);
> >+                addr++;
> >             }
> >         }
> > #endif
> >-- 
> >1.7.1
> 
> This patch fixes a regression introduced by commit
> d758525180e0efff8a59cfea11f5f8348014ff6a
> (More phys_ram_base elimination).
> 
> Please apply it to QEMU git master (with a modified subject, s/use/using/).
> 
> Tested-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to the trivial patches -next tree.

Stefan