From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWy9a-0003IC-7c for qemu-devel@nongnu.org; Sat, 03 Dec 2011 17:33:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RWy9Y-0005RW-Qy for qemu-devel@nongnu.org; Sat, 03 Dec 2011 17:33:54 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:44772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RWy9Y-0005RQ-CP for qemu-devel@nongnu.org; Sat, 03 Dec 2011 17:33:52 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 703E01BB1B8B1 for ; Sat, 3 Dec 2011 23:33:49 +0100 (CET) Message-ID: <4EDAA3C7.7060409@web.de> Date: Sat, 03 Dec 2011 23:33:43 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4EDA71B5.1060006@suse.de> In-Reply-To: <4EDA71B5.1060006@suse.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4AAB8728FE0FD0DE99E2F5E9" Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , Avi Kivity This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4AAB8728FE0FD0DE99E2F5E9 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-12-03 20:00, Andreas F=E4rber wrote: > Am 03.12.2011 12:17, schrieb Jan Kiszka: >> From: Jan Kiszka >> >> More KVM-specific devices will come, so let's start with moving the >> kvmclock into a dedicated folder. >> >> Signed-off-by: Jan Kiszka >> --- >=20 >> diff --git a/Makefile.target b/Makefile.target >> index 1e90df7..3a9e95d 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -231,7 +231,7 @@ obj-i386-y +=3D vmport.o >> obj-i386-y +=3D device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o >> obj-i386-y +=3D debugcon.o multiboot.o >> obj-i386-y +=3D pc_piix.o >> -obj-i386-$(CONFIG_KVM) +=3D kvmclock.o >> +obj-i386-$(CONFIG_KVM) +=3D kvm/clock.o >> obj-i386-$(CONFIG_SPICE) +=3D qxl.o qxl-logger.o qxl-render.o >> =20 >> # shared objects >=20 >> diff --git a/hw/kvmclock.c b/hw/kvm/clock.c >> similarity index 96% >> rename from hw/kvmclock.c >> rename to hw/kvm/clock.c >> index 5388bc4..aa37c5d 100644 >> --- a/hw/kvmclock.c >> +++ b/hw/kvm/clock.c >> @@ -11,11 +11,11 @@ >> * >> */ >> =20 >> -#include "qemu-common.h" >> -#include "sysemu.h" >> -#include "sysbus.h" >> -#include "kvm.h" >> -#include "kvmclock.h" >> +#include >> +#include >> +#include >> +#include >> +#include >> =20 >> #include >> #include >=20 > Please don't start using system includes for everything. Rather extend > QEMU_CFLAGS to contain the right user include path(s). No problem - and no need to tweak any CFLAGS ("" only adds . to the header search paths). Do we have a convention that every include in <> is considered system header? Should probably be documented then (and code should be converted gradually). Jan --------------enig4AAB8728FE0FD0DE99E2F5E9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7ao8oACgkQitSsb3rl5xR1lACfQ4ORJow9SIbItY/i7zXEAfCo J6UAnAjeOoHvU/LC3RNgsHByuDbzCIrm =roAr -----END PGP SIGNATURE----- --------------enig4AAB8728FE0FD0DE99E2F5E9--