From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXBrr-0001PX-Lu for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:12:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXBrp-0004JY-9Q for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:12:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXBrp-0004J9-1f for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:12:29 -0500 Message-ID: <4EDB71B6.5090508@redhat.com> Date: Sun, 04 Dec 2011 15:12:22 +0200 From: Avi Kivity MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl On 12/03/2011 01:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > Rename msix_supported to msi_supported and control MSI and MSI-X > activation this way. That was likely to original intention for this > flag, but MSI support came after MSI-X. 'and' is a dangerous word in a changelog entry. > > + > + if (!msi_supported) { > + return -ENOTSUP; > + } > + > This changes behaviour. qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will be different after this, no? -- error compiling committee.c: too many arguments to function