From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXBvS-0002MP-D0 for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:16:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXBvQ-0004jk-Ni for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:16:14 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:43872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXBvQ-0004jW-Cz for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:16:12 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 694F81A428701 for ; Sun, 4 Dec 2011 14:16:11 +0100 (CET) Message-ID: <4EDB7297.8030607@web.de> Date: Sun, 04 Dec 2011 14:16:07 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4EDB71B6.5090508@redhat.com> In-Reply-To: <4EDB71B6.5090508@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCE12E39A904DF6A1D3737245" Subject: Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCE12E39A904DF6A1D3737245 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-04 14:12, Avi Kivity wrote: > On 12/03/2011 01:17 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Rename msix_supported to msi_supported and control MSI and MSI-X >> activation this way. That was likely to original intention for this >> flag, but MSI support came after MSI-X. >=20 > 'and' is a dangerous word in a changelog entry. This patch hardly qualifies for two IMHO. >=20 >> >> + >> + if (!msi_supported) { >> + return -ENOTSUP; >> + } >> + >> >=20 > This changes behaviour. qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will= > be different after this, no? >=20 Only isapc had msix_supported =3D 0, and I doubt we got there (msi_init) for that machine. Or am I missing something? Jan --------------enigCE12E39A904DF6A1D3737245 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7bcpcACgkQitSsb3rl5xQ4WgCfQXEmxWK8shXVKbiz6Srniy3l 0CwAn2MQRCJVxbvVQEnw9/6+bs1OJq6d =tYuP -----END PGP SIGNATURE----- --------------enigCE12E39A904DF6A1D3737245--