From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXBzd-00039f-1G
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:20:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXBzb-0005KR-Sn
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:20:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51669)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXBzb-0005KG-LF
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:20:31 -0500
Message-ID: <4EDB739A.8080201@redhat.com>
Date: Sun, 04 Dec 2011 15:20:26 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1322910904.git.jan.kiszka@web.de>
	<eca7ce0c4550c1052b0258175d421aab048dc474.1322910904.git.jan.kiszka@web.de>
In-Reply-To: <eca7ce0c4550c1052b0258175d421aab048dc474.1322910904.git.jan.kiszka@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 10/16] memory: Introduce
	memory_region_init_reservation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>

On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Introduce a memory region type that can reserve I/O space. Such regions
> are useful for modeling I/O that is only handled outside of QEMU, i.e.
> in the context of an accelerator like KVM. Any access to such a region
> from QEMU is a bug and will be reported as such.

This is guest triggerable (DMA into the region), so abort() is too drastic.

> +void memory_region_init_reservation(MemoryRegion *mr,
> +                                    const char *name,
> +                                    uint64_t size)
> +{
> +    memory_region_init(mr, name, size);
> +    mr->ops = &reservation_ops;
> +    mr->opaque = mr;
> +    mr->terminates = true;
> +    mr->backend_registered = false;
> +}

Just calling memory_region_init_io() is simpler, no?


-- 
error compiling committee.c: too many arguments to function