From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXC5v-0003A7-4k
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:27:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXC5t-0006be-VS
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:27:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48761)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXC5t-0006bW-IZ
	for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:27:01 -0500
Message-ID: <4EDB7520.3030108@redhat.com>
Date: Sun, 04 Dec 2011 15:26:56 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1322910904.git.jan.kiszka@web.de>
	<fcf06b2d32d56e7877652ceb6b5f2d4841bda112.1322910904.git.jan.kiszka@web.de>
	<4EDB71B6.5090508@redhat.com> <4EDB7297.8030607@web.de>
In-Reply-To: <4EDB7297.8030607@web.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 01/16] msi: Generalize msix_supported
	to msi_supported
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>

On 12/04/2011 03:16 PM, Jan Kiszka wrote:
> On 2011-12-04 14:12, Avi Kivity wrote:
> > On 12/03/2011 01:17 PM, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Rename msix_supported to msi_supported and control MSI and MSI-X
> >> activation this way. That was likely to original intention for this
> >> flag, but MSI support came after MSI-X.
> > 
> > 'and' is a dangerous word in a changelog entry.
>
> This patch hardly qualifies for two IMHO.

If we don't have to change it, no.

>
> > 
> >>
> >> +
> >> +    if (!msi_supported) {
> >> +        return -ENOTSUP;
> >> +    }
> >> +
> >>
> > 
> > This changes behaviour.  qemu 1.0 -M pc-1.0 and qemu-1.1 -M pc-1.0 will
> > be different after this, no?
> > 
>
> Only isapc had msix_supported = 0, and I doubt we got there (msi_init)
> for that machine. Or am I missing something?
>

Ah, I thought it was a user-settable property, but it isn't.

-- 
error compiling committee.c: too many arguments to function