From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXXmN-0001kl-2q for qemu-devel@nongnu.org; Mon, 05 Dec 2011 07:36:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXXmI-0002MN-Uk for qemu-devel@nongnu.org; Mon, 05 Dec 2011 07:36:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXXmI-0002ME-Mq for qemu-devel@nongnu.org; Mon, 05 Dec 2011 07:36:14 -0500 Message-ID: <4EDCBAB8.10307@redhat.com> Date: Mon, 05 Dec 2011 14:36:08 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4EDB762C.7090909@redhat.com> <4EDB78DE.6000109@web.de> <4EDB7A74.4060804@redhat.com> <4EDB7ADC.50906@web.de> <4EDB7DE2.2050301@redhat.com> <4EDB7E62.7090909@web.de> <4EDB8DDE.5040402@redhat.com> <4EDB8F7C.1070602@web.de> <4EDBA15E.3060309@redhat.com> <4EDBE865.6000907@web.de> <4EDC9680.2070305@redhat.com> <4EDCAD01.2010608@web.de> In-Reply-To: <4EDCAD01.2010608@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl On 12/05/2011 01:37 PM, Jan Kiszka wrote: > On 2011-12-05 11:01, Avi Kivity wrote: > > On 12/04/2011 11:38 PM, Jan Kiszka wrote: > >>> > >>> It should be also possible to migrate from non-KVM device to KVM > >>> version, different names would prevent that for ever. > >> > >> It is (theoretically) possible with these patches as the vmstate names > >> are the same. KVM to TCG migration does not work right now, so I was > >> only able to test in-kernel <-> user space irqchip model migrations. > > > > btw, for the next-gen migration protocol, we'd probably be using QOM > > paths, not vmstate names; the QOM paths would include the device name? > > That would be a very bad idea IMHO. Every refactoring of your device > tree, e.g. to model CPU hotplug and the ICC bus more accurately, would > risk to create a migration crack. At some point, something has to be stable. We can't have an infinite number of layers giving names to things. I propose we have just one layer. > At least we would need some stable > naming and/or alias concept then. We should be able to transform a path to backward compatible names, yes. But if something has an unstable name, let's omit it in the first place. (the memory API added unstable names, hopefully the QOM can take over the stable ones and we'll have a good way to denote the unstable ones). -- error compiling committee.c: too many arguments to function