From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXYNU-0000g2-Ob for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:14:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXYNT-0003BF-NJ for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:14:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXYNT-0003B4-FR for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:14:39 -0500 Message-ID: <4EDCC3B8.9020203@redhat.com> Date: Mon, 05 Dec 2011 15:14:32 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4EDB762C.7090909@redhat.com> <4EDB78DE.6000109@web.de> <4EDB7A74.4060804@redhat.com> <4EDB7ADC.50906@web.de> <4EDB7DE2.2050301@redhat.com> <4EDB7E62.7090909@web.de> <4EDB8DDE.5040402@redhat.com> <4EDB8F7C.1070602@web.de> <4EDBA15E.3060309@redhat.com> <4EDBE865.6000907@web.de> <4EDC9680.2070305@redhat.com> <4EDCAD01.2010608@web.de> <4EDCBAB8.10307@redhat.com> <4EDCBD66.6010100@siemens.com> In-Reply-To: <4EDCBD66.6010100@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl On 12/05/2011 02:47 PM, Jan Kiszka wrote: > > > > (the memory API added unstable names, hopefully the QOM can take over > > the stable ones and we'll have a good way to denote the unstable ones). > > > > OK, maybe - or likely - we should make those device models have the same > names in QOM once instantiated. But I'm still convinced they should > remain separated models in contrast to a single model with a property. What do you mean by separate models? You share all the code you can, and don't share the code you can't. To me, single model == single name. > The kvm ioapic, e.g., requires an additional property (gsi_base) that is > meaningless for user space devices. And its interrupts have to be > wired&configured differently at board model level. So, from the QEMU > POV, it is a very different device. Just the guest does not notice. It's like qcow2 and raw/native IO are wire differently, or virtio-net and vhost-net. But it's the same IDE device or virtio NIC. -- error compiling committee.c: too many arguments to function