From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RXYzY-0001nD-49
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:54:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RXYzR-0003gL-PL
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:54:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4382)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RXYzR-0003g3-Ie
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 08:53:53 -0500
Message-ID: <4EDCCDAD.8090108@redhat.com>
Date: Mon, 05 Dec 2011 14:57:01 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1322655824-31778-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1322655824-31778-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait()
 issues
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Am 30.11.2011 13:23, schrieb Stefan Hajnoczi:
> This series fixes an issue where qemu_aio_flush() would return to IDE hardware
> emulation with requests still pending.  Kevin Wolf <kwolf@redhat.com> found it
> in the block tree before qemu.git/master merge, so qemu.git/master is not
> affected and these patches are against his tree.
> 
> A recent interaction between copy-on-read and "qcow2: Unlock during COW"
> emphasized the need for strong assertion checking.  Patch 1 fixes an assertion
> failure with qcow2 images in hw/ide/pci.c:bmdma_cmd_writeb().
> 
> Patches 2 and 3 then introduce assertions that detect
> wait_for_overlapping_requests() deadlock and broken qemu_aio_wait().  In the
> future we will have better information if issues related to qemu_aio_wait()
> come up.
> 
> I have run qemu-iotests for qcow2 and qed.  I have also performed a RHEL6 guest
> install to qed and tested booting the guest with IDE and qcow2.
> 
> Stefan Hajnoczi (3):
>   qcow2: avoid reentrant bdrv_read() in copy_sectors()
>   block: wait_for_overlapping_requests() deadlock detection
>   block: convert qemu_aio_flush() calls to bdrv_drain_all()

Thanks, applied all to the block branch.

Kevin