From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXqdo-00024P-Fz for qemu-devel@nongnu.org; Tue, 06 Dec 2011 03:44:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXqdn-0006Gy-GU for qemu-devel@nongnu.org; Tue, 06 Dec 2011 03:44:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXqdn-0006Gj-9H for qemu-devel@nongnu.org; Tue, 06 Dec 2011 03:44:43 -0500 Message-ID: <4EDDD5F6.3050000@redhat.com> Date: Tue, 06 Dec 2011 09:44:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1322839676-7559-1-git-send-email-cyliu@suse.com> <1322839676-7559-2-git-send-email-cyliu@suse.com> <4ED8FDA7.3090901@redhat.com> <4EDDCB7B.3060300@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] Extract code to nbd_setup function to be used for many purposes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On 12/06/2011 09:42 AM, Chunyan Liu wrote: > > I do not understand why you cannot simply do it like this: > > - in the server thread, do everything as it is now > > Nope. When device changes, both client thread and server thread should > be refreshed. sockpath and sharing_fds[] is changed with different device. Then let's change the default sockpath to include the pid rather than the NBD device name. Paolo