From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators
Date: Wed, 07 Dec 2011 17:54:41 +0200 [thread overview]
Message-ID: <4EDF8C41.1040304@redhat.com> (raw)
In-Reply-To: <4EDF8BDA.4030307@codemonkey.ws>
On 12/07/2011 05:52 PM, Anthony Liguori wrote:
> On 12/04/2011 12:09 PM, Avi Kivity wrote:
>> This patchset introduces memory_region_set_enabled() and
>> memory_region_set_address() to avoid the requirement on memory
>> routers to track the internal state of the memory API (so they know
>> whether they need to add or remove a region). Instead, they can
>> simply copy the state of the region from the guest-exposed register
>> to the memory core, via the new mutator functions.
>
> Based on previous discussions, any time these functions are used, the
> caller more than likely needs to call them again in a post_load hook
> during restore, correct?
>
> It would be good to document this very clearly in the header docs for
> each function.
It's a layering violation, but I'll add something.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-07 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 18:09 [Qemu-devel] [PATCH v2 0/6] Memory API mutators Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 1/6] memory: introduce memory_region_set_enabled() Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 2/6] memory: introduce memory_region_set_address() Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset() Avi Kivity
2011-12-04 21:34 ` Blue Swirl
2011-12-05 10:04 ` Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 4/6] memory: optimize empty transactions due to mutators Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 5/6] cirrus_vga: adapt to memory mutators API Avi Kivity
2011-12-04 18:09 ` [Qemu-devel] [PATCH v2 6/6] piix_pci: adapt smram mapping to use memory mutators Avi Kivity
2011-12-07 15:52 ` [Qemu-devel] [PATCH v2 0/6] Memory API mutators Anthony Liguori
2011-12-07 15:54 ` Avi Kivity [this message]
2011-12-07 15:56 ` Anthony Liguori
2011-12-07 15:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF8C41.1040304@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).