From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYJpd-00046U-H9 for qemu-devel@nongnu.org; Wed, 07 Dec 2011 10:54:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RYJpX-0000Hn-Hn for qemu-devel@nongnu.org; Wed, 07 Dec 2011 10:54:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYJpX-0000HG-Ad for qemu-devel@nongnu.org; Wed, 07 Dec 2011 10:54:47 -0500 Message-ID: <4EDF8C41.1040304@redhat.com> Date: Wed, 07 Dec 2011 17:54:41 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1323022181-28110-1-git-send-email-avi@redhat.com> <4EDF8BDA.4030307@codemonkey.ws> In-Reply-To: <4EDF8BDA.4030307@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 12/07/2011 05:52 PM, Anthony Liguori wrote: > On 12/04/2011 12:09 PM, Avi Kivity wrote: >> This patchset introduces memory_region_set_enabled() and >> memory_region_set_address() to avoid the requirement on memory >> routers to track the internal state of the memory API (so they know >> whether they need to add or remove a region). Instead, they can >> simply copy the state of the region from the guest-exposed register >> to the memory core, via the new mutator functions. > > Based on previous discussions, any time these functions are used, the > caller more than likely needs to call them again in a post_load hook > during restore, correct? > > It would be good to document this very clearly in the header docs for > each function. It's a layering violation, but I'll add something. -- error compiling committee.c: too many arguments to function