From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYNXL-0002FA-KT
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 14:52:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYNXJ-0006w4-V8
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 14:52:15 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYNXJ-0006vz-PD
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 14:52:13 -0500
Message-ID: <4EDFC3C3.7010206@weilnetz.de>
Date: Wed, 07 Dec 2011 20:51:31 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1323244048-6021-1-git-send-email-balrogg@gmail.com>	<4EDFB719.7060904@weilnetz.de>
	<CAOq732+7YtvkWvQC-fFoZZ88Nj1orc8hQOCvBVu+-kgA7WKhig@mail.gmail.com>
In-Reply-To: <CAOq732+7YtvkWvQC-fFoZZ88Nj1orc8hQOCvBVu+-kgA7WKhig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: don't try to compile against
 known broken curses.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org

Am 07.12.2011 20:06, schrieb andrzej zaborowski:
> On 7 December 2011 19:57, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
>>> +#ifdef NCURSES_VERSION
>>> +# if NCURSES_VERSION_PATCH < 20040117
>>> +# error Old ncurses contain dangerous typedefs, break qemu build 
>>> (and are
>>> old)
>>> +# endif
>>> +#endif
>>> int main(void) { resize_term(0, 0); return curses_version(); }
>>> EOF
>>> for curses_lib in $curses_list; do
>>
>>
>> Is NCURSES_VERSION_PATCH always defined when NCURSES_VERSION is?
>
> I'm not sure, will try to find out. If it isn't then we should check
> that NCURSES_VERSION_MINOR < 4 perhaps.
>
> The intent of checking defined(NCURSES_VERSION) is to detect ncurses
> because qemu should also build with other implementations of curses
> (in theory).
>
> Cheers

Yes, that's right. W32 for example supports pdcurses. So the check
might look like this:

#if defined(NCURSES_VERSION_PATCH) && NCURSES_VERSION_PATCH < 20040117
# error Old ncurses contain dangerous typedefs, break qemu build (and 
are old)
#endif

Cheers,
Stefan