From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RYS4V-0007pf-Rf
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 19:42:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RYS4V-0002il-1L
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 19:42:47 -0500
Received: from mout.web.de ([212.227.15.4]:58017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RYS4U-0002if-Lk
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 19:42:47 -0500
Message-ID: <4EE007C5.4060109@web.de>
Date: Thu, 08 Dec 2011 01:41:41 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1320950407-43512-1-git-send-email-pavel.borzenkov@gmail.com>
	<1320950407-43512-4-git-send-email-pavel.borzenkov@gmail.com>
In-Reply-To: <1320950407-43512-4-git-send-email-pavel.borzenkov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: Andrzej Zaborowski <andrew.zaborowski@intel.com>, qemu-devel@nongnu.org, Ben Leslie <benno@benno.id.au>

Am 10.11.2011 19:40, schrieb Pavel Borzenkov:
> When SDL support is disabled, there is no way to build QEMU without
> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
> allows to build QEMU without both SDL and Cocoa frontends.
> 
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> ---
>  configure |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/configure b/configure
> index 401d9a6..4720bb2 100755
> --- a/configure
> +++ b/configure
> @@ -670,6 +670,8 @@ for opt do
>    ;;
>    --enable-profiler) profiler="yes"
>    ;;
> +  --disable-cocoa) cocoa="no"
> +  ;;
>    --enable-cocoa)
>        cocoa="yes" ;
>        sdl="no" ;

Tested-by: Andreas Färber <andreas.faerber@web.de>

> @@ -980,7 +982,10 @@ echo "  --disable-sdl            disable SDL"
>  echo "  --enable-sdl             enable SDL"
>  echo "  --disable-vnc            disable VNC"
>  echo "  --enable-vnc             enable VNC"
> -echo "  --enable-cocoa           enable COCOA (Mac OS X only)"
> +if test "$darwin" = "yes" ; then
> +    echo "  --disable-cocoa          disable COCOA"
> +    echo "  --enable-cocoa           enable COCOA (default)"
> +fi
>  echo "  --audio-drv-list=LIST    set audio drivers list:"
>  echo "                           Available drivers: $audio_possible_drivers"
>  echo "  --audio-card-list=LIST   set list of emulated audio cards [$audio_card_list]"

I see no prior art of any conditional help output in configure. Anthony?
Andrzej?

Andreas