qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: hkran <hkran@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
Date: Wed, 07 Dec 2011 20:30:42 -0600	[thread overview]
Message-ID: <4EE02152.5070606@codemonkey.ws> (raw)
In-Reply-To: <4EDF345C.5060304@linux.vnet.ibm.com>

On 12/07/2011 03:39 AM, hkran wrote:
> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>

A Signed-off-by line needs to use your full name.

Regards,

Anthony Liguori

> ---
> hw/virtio-pci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index c665f5c..f8ee772 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev)
> if (proxy->class_code) {
> pci_config_set_class(config, proxy->class_code);
> }
> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
> - pci_set_word(config + 0x2e, vdev->device_id);
> - config[0x3d] = 1;
> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config +
> PCI_VENDOR_ID));
> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
> + config[PCI_INTERRUPT_PIN] = 1;
>
> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,

  parent reply	other threads:[~2011-12-08  2:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07  9:39 [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci hkran
2011-12-07 10:18 ` Stefan Hajnoczi
2011-12-08  2:28   ` hkran
2011-12-08  2:30 ` Anthony Liguori [this message]
2011-12-09  3:32   ` hkran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE02152.5070606@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=hkran@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).