From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RYTl1-0003TM-J5
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 21:30:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RYTl0-0003q7-H7
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 21:30:47 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:33127)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RYTl0-0003q0-Dw
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 21:30:46 -0500
Received: by iafj26 with SMTP id j26so2085900iaf.4
	for <qemu-devel@nongnu.org>; Wed, 07 Dec 2011 18:30:45 -0800 (PST)
Message-ID: <4EE02152.5070606@codemonkey.ws>
Date: Wed, 07 Dec 2011 20:30:42 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4EDF345C.5060304@linux.vnet.ibm.com>
In-Reply-To: <4EDF345C.5060304@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: hkran <hkran@linux.vnet.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 12/07/2011 03:39 AM, hkran wrote:
> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>

A Signed-off-by line needs to use your full name.

Regards,

Anthony Liguori

> ---
> hw/virtio-pci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index c665f5c..f8ee772 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev)
> if (proxy->class_code) {
> pci_config_set_class(config, proxy->class_code);
> }
> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
> - pci_set_word(config + 0x2e, vdev->device_id);
> - config[0x3d] = 1;
> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config +
> PCI_VENDOR_ID));
> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
> + config[PCI_INTERRUPT_PIN] = 1;
>
> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,