From: "Jorge Acereda Maciá" <jacereda@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kraxel@redhat.com, aliguori@amazon.com
Subject: [Qemu-devel] [PATCH] Fix crash when connecting to VNC through websocket
Date: Sun, 22 Feb 2015 22:58:30 +0100 [thread overview]
Message-ID: <4EE0ACB8-AA07-4A62-92D1-AF866DA241FB@gmail.com> (raw)
Connecting to VNC through websocket crashes in vnc_flush() when trying
to acquire a mutex that hasn't been initialized (vnc_init_state(vs)
hasn't been called at this point).
Signed-off-by: Jorge Acereda Macia <jacereda@gmail.com>
---
ui/vnc-ws.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/vnc-ws.c b/ui/vnc-ws.c
index e304baf..30cb3ae 100644
--- a/ui/vnc-ws.c
+++ b/ui/vnc-ws.c
@@ -208,7 +208,7 @@ static void vncws_send_handshake_response(VncState *vs, const char* key)
response = g_strdup_printf(WS_HANDSHAKE, accept);
vnc_write(vs, response, strlen(response));
- vnc_flush(vs);
+ vnc_client_write_ws(vs);
g_free(accept);
g_free(response);
--
1.9.3 (Apple Git-50)
next reply other threads:[~2015-02-22 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 21:58 Jorge Acereda Maciá [this message]
2015-02-23 7:33 ` [Qemu-devel] [PATCH] Fix crash when connecting to VNC through websocket Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2015-02-24 0:29 Jorge Acereda Maciá
2015-02-24 6:09 ` Peter Crosthwaite
2015-02-24 16:33 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE0ACB8-AA07-4A62-92D1-AF866DA241FB@gmail.com \
--to=jacereda@gmail.com \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).