From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYp35-0002h0-31 for qemu-devel@nongnu.org; Thu, 08 Dec 2011 20:14:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RYp33-0004vy-FJ for qemu-devel@nongnu.org; Thu, 08 Dec 2011 20:14:51 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:35074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYp33-0004vq-23 for qemu-devel@nongnu.org; Thu, 08 Dec 2011 20:14:49 -0500 Received: from /spool/local by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Dec 2011 20:14:47 -0500 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB91Ejuu3625168 for ; Thu, 8 Dec 2011 20:14:45 -0500 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB91EiRo029552 for ; Thu, 8 Dec 2011 20:14:45 -0500 Message-ID: <4EE16103.6090509@linux.vnet.ibm.com> Date: Thu, 08 Dec 2011 19:14:43 -0600 From: Michael Roth MIME-Version: 1.0 References: <20111208165258.17ab95f7@doriath> In-Reply-To: <20111208165258.17ab95f7@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] qemu-ga: Introduce guest-hibernate command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Amit Shah , qemu-devel On 12/08/2011 12:52 PM, Luiz Capitulino wrote: > This is basically suspend to disk on a Linux guest. Nice! > > Signed-off-by: Luiz Capitulino > --- > > This is an RFC because I did it as simple as possible and I'm open to > suggestions... > > Now, while testing this or even "echo disk> /sys/power/state" I get several > funny results. Some times qemu just dies after printing that message: > > "Guest moved used index from 20151 to 1" > > Some times it doesn't die, but I'm unable to log into the guest: I type > username& password but the terminal kind of locks (the shell doesn't run). Triggered this pretty easily on FC15 amd64: qemu-system-x86_64: Guest moved used index from 13024 to 80 I'll see if I can get a trace of what's happening on my end. > > Some times it works... > > qapi-schema-guest.json | 11 +++++++++++ > qga/guest-agent-commands.c | 19 +++++++++++++++++++ > 2 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json > index fde5971..2c5bbcf 100644 > --- a/qapi-schema-guest.json > +++ b/qapi-schema-guest.json > @@ -215,3 +215,14 @@ > ## > { 'command': 'guest-fsfreeze-thaw', > 'returns': 'int' } > + > +## > +# @guest-hibernate > +# > +# Save RAM contents to disk and powerdown the guest. > +# > +# Notes: This command doesn't return on success. > +# > +# Since: 1.1 > +## > +{ 'command': 'guest-hibernate' } > diff --git a/qga/guest-agent-commands.c b/qga/guest-agent-commands.c > index 6da9904..9dd4060 100644 > --- a/qga/guest-agent-commands.c > +++ b/qga/guest-agent-commands.c > @@ -550,6 +550,25 @@ int64_t qmp_guest_fsfreeze_thaw(Error **err) > } > #endif > > +#define LINUX_SYS_STATE_FILE "/sys/power/state" > + > +void qmp_guest_hibernate(Error **err) > +{ > + int fd; > + > + fd = open(LINUX_SYS_STATE_FILE, O_WRONLY); > + if (fd< 0) { > + error_set(err, QERR_OPEN_FILE_FAILED, LINUX_SYS_STATE_FILE); > + return; > + } > + > + if (write(fd, "disk", 4)< 0) { > + error_set(err, QERR_UNDEFINED_ERROR); > + } There's basically no chance of this returning, so we should issue it asynchronously like we do with qmp_guest_shutdown(). Also agreed on Daniel's point that we should use pm-hibernate, but failing back to this should be okay...assuming the virtio issue isn't indicative of some fundamental problem with that approach... > + > + close(fd); > +} > + > /* register init/cleanup routines for stateful command groups */ > void ga_command_state_init(GAState *s, GACommandState *cs) > {