From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYrCv-0003te-M3 for qemu-devel@nongnu.org; Thu, 08 Dec 2011 22:33:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RYrCu-00064V-Me for qemu-devel@nongnu.org; Thu, 08 Dec 2011 22:33:09 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:45200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYrCu-00064M-5M for qemu-devel@nongnu.org; Thu, 08 Dec 2011 22:33:08 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Dec 2011 03:31:16 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB93WTSD5115992 for ; Fri, 9 Dec 2011 14:32:32 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB93WTnV003796 for ; Fri, 9 Dec 2011 14:32:29 +1100 Message-ID: <4EE1814B.60605@linux.vnet.ibm.com> Date: Fri, 09 Dec 2011 11:32:27 +0800 From: hkran MIME-Version: 1.0 References: <4EDF345C.5060304@linux.vnet.ibm.com> <4EE02152.5070606@codemonkey.ws> In-Reply-To: <4EE02152.5070606@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On 12/08/2011 10:30 AM, Anthony Liguori wrote: > On 12/07/2011 03:39 AM, hkran wrote: >> Signed-off-by: hkran > > A Signed-off-by line needs to use your full name. > > Regards, > > Anthony Liguori > >> --- >> hw/virtio-pci.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c >> index c665f5c..f8ee772 100644 >> --- a/hw/virtio-pci.c >> +++ b/hw/virtio-pci.c >> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, >> VirtIODevice *vdev) >> if (proxy->class_code) { >> pci_config_set_class(config, proxy->class_code); >> } >> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID)); >> - pci_set_word(config + 0x2e, vdev->device_id); >> - config[0x3d] = 1; >> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config + >> PCI_VENDOR_ID)); >> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id); >> + config[PCI_INTERRUPT_PIN] = 1; >> >> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096); >> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors, > Signed-off-by: Hui Kai Ran