* [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
@ 2011-12-07 9:39 hkran
2011-12-07 10:18 ` Stefan Hajnoczi
2011-12-08 2:30 ` Anthony Liguori
0 siblings, 2 replies; 5+ messages in thread
From: hkran @ 2011-12-07 9:39 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori
Signed-off-by: hkran <hkran@linux.vnet.ibm.com>
---
hw/virtio-pci.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index c665f5c..f8ee772 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy,
VirtIODevice *vdev)
if (proxy->class_code) {
pci_config_set_class(config, proxy->class_code);
}
- pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
- pci_set_word(config + 0x2e, vdev->device_id);
- config[0x3d] = 1;
+ pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config
+ PCI_VENDOR_ID));
+ pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
+ config[PCI_INTERRUPT_PIN] = 1;
memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
2011-12-07 9:39 [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci hkran
@ 2011-12-07 10:18 ` Stefan Hajnoczi
2011-12-08 2:28 ` hkran
2011-12-08 2:30 ` Anthony Liguori
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2011-12-07 10:18 UTC (permalink / raw)
To: hkran; +Cc: aliguori, qemu-devel
On Wed, Dec 7, 2011 at 9:39 AM, hkran <hkran@linux.vnet.ibm.com> wrote:
> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>
> ---
> hw/virtio-pci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
This patch is line-wrapped and git-am refuses to apply it.
Are you using git-send-email(1)? It normally sends patches correctly
so I recommend it if you are not yet using it.
Otherwise this looks good and we can take it into the trivial-patches
tree. Please resend without line wrap.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
2011-12-07 10:18 ` Stefan Hajnoczi
@ 2011-12-08 2:28 ` hkran
0 siblings, 0 replies; 5+ messages in thread
From: hkran @ 2011-12-08 2:28 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: aliguori, qemu-devel
On 12/07/2011 06:18 PM, Stefan Hajnoczi wrote:
> On Wed, Dec 7, 2011 at 9:39 AM, hkran<hkran@linux.vnet.ibm.com> wrote:
>> Signed-off-by: hkran<hkran@linux.vnet.ibm.com>
>> ---
>> hw/virtio-pci.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
> This patch is line-wrapped and git-am refuses to apply it.
>
> Are you using git-send-email(1)? It normally sends patches correctly
> so I recommend it if you are not yet using it.
>
> Otherwise this looks good and we can take it into the trivial-patches
> tree. Please resend without line wrap.
>
> Stefan
>
ok,thanks for reviewing. I will resend it with git-publish:)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
2011-12-07 9:39 [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci hkran
2011-12-07 10:18 ` Stefan Hajnoczi
@ 2011-12-08 2:30 ` Anthony Liguori
2011-12-09 3:32 ` hkran
1 sibling, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2011-12-08 2:30 UTC (permalink / raw)
To: hkran; +Cc: qemu-devel
On 12/07/2011 03:39 AM, hkran wrote:
> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>
A Signed-off-by line needs to use your full name.
Regards,
Anthony Liguori
> ---
> hw/virtio-pci.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index c665f5c..f8ee772 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev)
> if (proxy->class_code) {
> pci_config_set_class(config, proxy->class_code);
> }
> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
> - pci_set_word(config + 0x2e, vdev->device_id);
> - config[0x3d] = 1;
> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config +
> PCI_VENDOR_ID));
> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
> + config[PCI_INTERRUPT_PIN] = 1;
>
> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci
2011-12-08 2:30 ` Anthony Liguori
@ 2011-12-09 3:32 ` hkran
0 siblings, 0 replies; 5+ messages in thread
From: hkran @ 2011-12-09 3:32 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On 12/08/2011 10:30 AM, Anthony Liguori wrote:
> On 12/07/2011 03:39 AM, hkran wrote:
>> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>
>
> A Signed-off-by line needs to use your full name.
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> hw/virtio-pci.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index c665f5c..f8ee772 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy,
>> VirtIODevice *vdev)
>> if (proxy->class_code) {
>> pci_config_set_class(config, proxy->class_code);
>> }
>> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
>> - pci_set_word(config + 0x2e, vdev->device_id);
>> - config[0x3d] = 1;
>> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config +
>> PCI_VENDOR_ID));
>> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
>> + config[PCI_INTERRUPT_PIN] = 1;
>>
>> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
>> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,
>
Signed-off-by: Hui Kai Ran <hkran@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-12-09 3:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-07 9:39 [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci hkran
2011-12-07 10:18 ` Stefan Hajnoczi
2011-12-08 2:28 ` hkran
2011-12-08 2:30 ` Anthony Liguori
2011-12-09 3:32 ` hkran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).